MD Settings: Reset profile dialog, display settings in new tab.

chrome/browser/resources/settings/reset_page/reset_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings', function() {
   /** @interface */
   function ResetBrowserProxy() {}
 
   ResetBrowserProxy.prototype = {
     /**
      * @param {boolean} sendSettings Whether the user gave consent to upload
      *     broken settings to Google for analysis.

[tommycli, 2016/04/20 23:23:18]

nit (optional): Are the settings really "broken settings", or just the "current
settings (about to be reset)".

      * @return {!Promise} A promise firing once resetting has completed.
      */
     performResetProfileSettings: function(sendSettings) {},
 
     /**
      * A method to be called when the reset profile dialog is hidden.
      */
     onHideResetProfileDialog: function() {},
 
     /**
      * A method to be called when the reset profile banner is hidden.
      */
     onHideResetProfileBanner: function() {},
 
     /**
      * A method to be called when the reset profile dialog is shown.
      */
     onShowResetProfileDialog: function() {},
 
+    /** @return {!Promise<!Array<{key:string, value:string}>} */

[tommycli, 2016/04/20 23:23:18]

nit would be good to add a comment perhaps:

"Gets the current settings (about to be reset) reported to Google for analysis."

[dpapad, 2016/04/21 00:27:10]

Done.

+    getReportedSettings: function() {},
+
 <if expr="chromeos">
     /**
      * A method to be called when the reset powerwash dialog is shown.
      */
     onPowerwashDialogShow: function() {},
 
     /**
      * Initiates a factory reset and restarts ChromeOS.
      */
     requestFactoryResetRestart: function() {},
@@ skipping 21 matching lines @@
     /** @override */
     onHideResetProfileBanner: function() {
       chrome.send('onHideResetProfileBanner');
     },
 
     /** @override */
     onShowResetProfileDialog: function() {
       chrome.send('onShowResetProfileDialog');
     },
 
+    /** @override */
+    getReportedSettings: function() {
+      return cr.sendWithPromise('getReportedSettings');
+    },
+
 <if expr="chromeos">
     /** @override */
     onPowerwashDialogShow: function() {
       chrome.send('onPowerwashDialogShow');
     },
 
     /** @override */
     requestFactoryResetRestart: function() {
       chrome.send('requestFactoryResetRestart');
     },
 </if>
   };
 
   return {
     ResetBrowserProxyImpl: ResetBrowserProxyImpl,
   };
 });