Teach SiteInstance::GetSiteForURL() about blob and filesystem URLs.

chrome/browser/search/search.cc

Index: chrome/browser/search/search.cc
diff --git a/chrome/browser/search/search.cc b/chrome/browser/search/search.cc
index 645fecb9a52e535b344cc9554331c891695ddc61..0e6a7c608c9936226a9d049c25a684153f10f6a8 100644
--- a/chrome/browser/search/search.cc
+++ b/chrome/browser/search/search.cc
@@ -493,6 +493,7 @@ GURL GetEffectiveURLForInstant(const GURL& url, Profile* profile) {
   // Replace the scheme with "chrome-search:".
   url::Replacements<char> replacements;
   std::string search_scheme(chrome::kChromeSearchScheme);
+  replacements.ClearPort();

[Charlie Reis, 2016/04/22 18:11:09]

I'll defer to Samarth or someone familiar with the NTP code here, since this
would be a problem if we later pulled the host out and tried to use it.  It does
seem a little counter-intuitive to me, since the only reason we need to do this
is because the scheme was declared as not having a port.

I'd say that we should declare the scheme as having a port instead, since it
does have a network host embedded in it in some (if not all) cases.

[ncarter (slow), 2016/04/22 20:00:34]

We're erasing the underlying scheme anyway (which is usually https://, except in
tests, where we allow it to be overridden) so even if we preserve the port,
conversion from a chrome-search:// URL back to a network URL doesn't seem
possible without extra information.

I'm guessing that's why this extra erasure doesn't break tests -- they'd already
be broken if they assumed https?

Or to think about it differently: if we think of the chrome-search scheme as
having a network port, is the default value 80 or 443?

[Charlie Reis, 2016/04/22 20:20:46]

That's a good point about losing the scheme.  That does suggest that the port is
unlikely to be needed from a chrome-search:// URL, since we can't meaningfully
recover the original URL from this one.

Thus, I think I'm ok with leaving it as SCHEME_WITHOUT_PORT and clearing it
here.  (Please add a comment about it, though, so we remember if we come back to
it later.)

The downside is that the chrome-search://foo.com URL can't distinguish between
variations of foo.com if the default search provider changes (e.g., between
ports or http/https), but that's of course a problem already today with
http/https.

   replacements.SetScheme(search_scheme.data(),
                          url::Component(0, search_scheme.length()));