Teach SiteInstance::GetSiteForURL() about blob and filesystem URLs.

chrome/browser/search/search_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram_base.h"
@@ skipping 167 matching lines @@
     {"chrome-search://local-ntp",      true,  "Local NTP"},
     {"chrome-search://remote-ntp",     true,  "Remote NTP"},
     {"invalid-scheme://local-ntp",     false, "Invalid Local NTP URL"},
     {"invalid-scheme://online-ntp",    false, "Invalid Online NTP URL"},
     {"chrome-search://foo.com",        false, "Search result page"},
     {"https://foo.com/instant?strk",   false,  ""},
     {"https://foo.com/instant#strk",   false,  ""},
     {"https://foo.com/instant?strk=0", false,  ""},
     {"https://foo.com/url?strk",       false,  ""},
     {"https://foo.com/alt?strk",       false,  ""},
+    {"https://foo.com:80/instant",     false,  "HTTPS with port"},
     {"http://foo.com/instant",         false,  "Non-HTTPS"},
     {"http://foo.com/instant?strk",    false,  "Non-HTTPS"},
     {"http://foo.com/instant?strk=1",  false,  "Non-HTTPS"},
+    {"http://foo.com:443/instant",     false,  "Non-HTTPS"},
     {"https://foo.com/instant",        false,  "No search terms replacement"},
     {"https://foo.com/?strk",          false,  "Non-exact path"},
   };
 
   for (size_t i = 0; i < arraysize(kTestCases); ++i) {
     const SearchTestCase& test = kTestCases[i];
     EXPECT_EQ(test.expected_result,
               ShouldUseProcessPerSiteForInstantURL(GURL(test.url), profile()))
         << test.url << " " << test.comment;
   }
@@ skipping 386 matching lines @@
 TEST_F(SearchTest,
        ShouldPrerenderInstantUrlOnOmniboxFocus_EnabledViaFieldTrial) {
   ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
       "EmbeddedSearch",
       "Group1 espv:80 prerender_instant_url_on_omnibox_focus:1"));
   EXPECT_TRUE(ShouldPrerenderInstantUrlOnOmniboxFocus());
   EXPECT_EQ(80ul, EmbeddedSearchPageVersion());
 }
 
 
-
 TEST_F(SearchTest, ShouldShowGoogleLocalNTP_Default) {
   EXPECT_TRUE(ShouldShowGoogleLocalNTP());
 }
 
 TEST_F(SearchTest, ShouldShowGoogleLocalNTP_EnabledViaFinch) {
   ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
       "EmbeddedSearch", "Group1 espv:2 google_local_ntp:1"));
   EXPECT_TRUE(ShouldShowGoogleLocalNTP());
 }
 
@@ skipping 85 matching lines @@
   };
 
   for (size_t i = 0; i < arraysize(kTestCases); ++i) {
     const QueryExtractionAllowedTestCase& test = kTestCases[i];
     EXPECT_EQ(test.expected_result,
               IsQueryExtractionAllowedForURL(profile(), GURL(test.url)))
         << test.url << " " << test.comment;
   }
 }
 
+// Regression test for https://crbug.com/605720: Set up a search provider backed
+// by localhost on a specific port, like browsertests do.  The chrome-search://
+// URLs generated in this mode should not have ports.
+TEST_F(SearchTest, SearchProviderWithPort) {
+  TemplateURLService* template_url_service =
+      TemplateURLServiceFactory::GetForProfile(profile());
+  TemplateURLData data;
+  data.SetShortName(base::ASCIIToUTF16("localhost"));
+  data.SetURL("https://[::1]:1993/url?bar={searchTerms}");
+  data.instant_url =
+      "https://[::1]:1993/instant?"
+      "{google:forceInstantResults}foo=foo#foo=foo&strk";
+  data.new_tab_url = "https://[::1]:1993/newtab?strk";
+  data.alternate_urls.push_back("https://[::1]:1993/alt#quux={searchTerms}");
+  data.search_terms_replacement_key = "strk";
+
+  TemplateURL* template_url = new TemplateURL(data);
+  template_url_service->Add(template_url); // Takes ownership of |template_url|.
+  template_url_service->SetUserSelectedDefaultSearchProvider(template_url);
+
+  EXPECT_TRUE(ShouldAssignURLToInstantRenderer(
+      GURL("https://[::1]:1993/newtab?lala"), profile()));
+  EXPECT_FALSE(ShouldAssignURLToInstantRenderer(
+      GURL("https://[::1]:1992/newtab?lala"), profile()));
+  EXPECT_EQ(GURL("chrome-search://remote-ntp/newtab?lala"),
+            GetEffectiveURLForInstant(GURL("https://[::1]:1993/newtab?lala"),
+                                      profile()));
+  EXPECT_EQ(GURL("chrome-search://[::1]/instant?strk"),
+            GetEffectiveURLForInstant(GURL("https://[::1]:1993/instant?strk"),
+                                      profile()));
+  EXPECT_FALSE(ShouldAssignURLToInstantRenderer(
+      GURL("https://[::1]:1993/unregistered-path?strk"), profile()));
+}
+
 class SearchURLTest : public SearchTest {
  protected:
   void SetSearchProvider(bool set_ntp_url, bool insecure_ntp_url) override {
     TemplateURLService* template_url_service =
         TemplateURLServiceFactory::GetForProfile(profile());
     TemplateURLData data;
     data.SetShortName(base::ASCIIToUTF16("Google"));
     data.SetURL("{google:baseURL}search?"
                 "{google:instantExtendedEnabledParameter}q={searchTerms}");
     data.search_terms_replacement_key = "espv";
@@ skipping 25 matching lines @@
   TemplateURLRef::SearchTermsArgs search_terms_args(base::ASCIIToUTF16("foo"));
   GURL result(template_url_->url_ref().ReplaceSearchTerms(
       search_terms_args, UIThreadSearchTermsData(profile())));
   ASSERT_TRUE(result.is_valid());
   // Query extraction is disabled. Make sure
   // {google:instantExtendedEnabledParameter} is not set in the search URL.
   EXPECT_EQ("http://www.google.com/search?q=foo", result.spec());
 }
 
 }  // namespace search