chrome/browser/ui/views/constrained_window_views.cc - Issue 19115003: Make the maximize button more easily hittable when there is a huge amount of tabs present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/constrained_window_views.cc

Issue 19115003: Make the maximize button more easily hittable when there is a huge amount of tabs present (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changed completely Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/wm/system_gesture_event_filter_unittest.cc ('k') | chrome/browser/ui/views/extensions/shell_window_frame_view.h » ('j') | chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/constrained_window_views.cc

diff --git a/chrome/browser/ui/views/constrained_window_views.cc b/chrome/browser/ui/views/constrained_window_views.cc

index bc7bb6858958ff9257ac77777ff9ab6b5f892cd2..6b30e1e9d163c91f36c28bc37882c02b5b41f8cd 100644

--- a/chrome/browser/ui/views/constrained_window_views.cc

+++ b/chrome/browser/ui/views/constrained_window_views.cc

@@ -255,7 +255,7 @@ class ConstrainedWindowFrameView : public views::NonClientFrameView,

virtual gfx::Rect GetBoundsForClientView() const OVERRIDE;

virtual gfx::Rect GetWindowBoundsForClientBounds(

const gfx::Rect& client_bounds) const OVERRIDE;

- virtual int NonClientHitTest(const gfx::Point& point) OVERRIDE;

+ virtual int NonClientHitTest(const gfx::Point& point) const OVERRIDE;

virtual void GetWindowMask(const gfx::Size& size,

gfx::Path* window_mask) OVERRIDE;

virtual void ResetWindowControls() OVERRIDE {}

@@ -411,7 +411,8 @@ gfx::Rect ConstrainedWindowFrameView::GetWindowBoundsForClientBounds(

client_bounds.height() + top_height + border_thickness);

}

-int ConstrainedWindowFrameView::NonClientHitTest(const gfx::Point& point) {

+int ConstrainedWindowFrameView::NonClientHitTest(

+ const gfx::Point& point) const {

if (!bounds().Contains(point))

return HTNOWHERE;