third_party/WebKit/Source/core/dom/DOMImplementation.cpp - Issue 1911493004: Don't copy the security origin when creating a document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMImplementation.cpp

Issue 1911493004: Don't copy the security origin when creating a document (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/create-document-unique-origin.html ('K') | « third_party/WebKit/LayoutTests/http/tests/security/create-document-unique-origin-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/DOMImplementation.cpp

diff --git a/third_party/WebKit/Source/core/dom/DOMImplementation.cpp b/third_party/WebKit/Source/core/dom/DOMImplementation.cpp

index 37f82e49650d48381a2b84499e39c9a40ffedd2f..333672323185e09b12912b1273b5fa9f952da702 100644

--- a/third_party/WebKit/Source/core/dom/DOMImplementation.cpp

+++ b/third_party/WebKit/Source/core/dom/DOMImplementation.cpp

@@ -88,7 +88,7 @@ XMLDocument* DOMImplementation::createDocument(const AtomicString& namespaceURI,

doc = XMLDocument::create(init);

}

- doc->setSecurityOrigin(document().getSecurityOrigin()->isolatedCopy());

+ doc->setSecurityOrigin(document().getSecurityOrigin());

doc->setContextFeatures(document().contextFeatures());

Node* documentElement = nullptr;

@@ -210,7 +210,7 @@ HTMLDocument* DOMImplementation::createHTMLDocument(const String& title)

headElement->appendChild(titleElement);

titleElement->appendChild(d->createTextNode(title), ASSERT_NO_EXCEPTION);

}

- d->setSecurityOrigin(document().getSecurityOrigin()->isolatedCopy());

+ d->setSecurityOrigin(document().getSecurityOrigin());

d->setContextFeatures(document().contextFeatures());

return d;

}