Upgrade build and clang.

Upgrade build and clang.

The issue with //testing/multiprocess_func_list has been fixed in upstream
//build. This Cl upgrades //build to ToT.

In order to do so clang must also be updated. The Wno-undefined-var-template
is only passed if the pinned clang revision isn't 266460, which is the
currently pinned clang revision in chromium. This is there so that the bot
that builds with trunk clang gets this flag, but pinned clang doesn't.

We accidentally pickup the flag since our pinned clang is different from the
Chrome version. So, we must always roll //build and clang together when
changing deps or bad things may happen as there is an implicit dependency
due to compile flags.

BUG=pdfium:106
Committed: https://pdfium.googlesource.com/pdfium/+/6b2c4d7d709dbfca0a59ce6310c0941669d0f53e

[dsinclair, 2016-04-20 16:54:58]

dsinclair@chromium.org changed reviewers:
+ thakis@chromium.org, thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-20 16:54:59]

PTAL.

[Nico, 2016-04-20 16:59:25]

the cl looks good, but the description is incorrect: Wno-undefined-var-template
is only passed if the pinned clang revision isn't 266460, which is the currently
pinned clang revision in chromium. This is there so that the bot that builds
with trunk clang gets this flag, but pinned clang doesn't. Since you're using a
different pinned clang atm, you're accidentally picking up the flag.
I think this means if you deps in build and clang, you must always roll these at
the same time, since they implicitly depend on each other (via compiler flags).

[Nico, 2016-04-20 16:59:32]

*the cl lgtm, but...

[Tom Sepez, 2016-04-20 17:08:32]

Deferring to Nico.

[dsinclair, 2016-04-20 17:47:06]

Description was changed from

==========
Upgrade build and clang.

The issue with //testing/multiprocess_func_list has been fixed in upstream
//build. This Cl upgrades //build to ToT. In order to do so clang must also
be updated so we can recognize the '-Wno-undefined-var-template' flag which
was added.

BUG=pdfium:106
==========

to

==========
Upgrade build and clang.

The issue with //testing/multiprocess_func_list has been fixed in upstream
//build. This Cl upgrades //build to ToT.

In order to do so clang must also be updated. The Wno-undefined-var-template
is only passed if the pinned clang revision isn't 266460, which is the
currently pinned clang revision in chromium. This is there so that the bot
that builds with trunk clang gets this flag, but pinned clang doesn't.

We accidentally pickup the flag since our pinned clang is different from the
Chrome version. So, we must always roll //build and clang together when
changing deps or bad things may happen as there is an implicit dependency
due to compile flags.

BUG=pdfium:106
==========

[dsinclair, 2016-04-20 17:47:16]

On 2016/04/20 16:59:32, Nico wrote:
> *the cl lgtm, but...

Updated description.

[dsinclair, 2016-04-20 17:47:23]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-20 17:47:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911483002/1

[commit-bot: I haz the power, 2016-04-20 17:47:50]

Description was changed from

==========
Upgrade build and clang.

The issue with //testing/multiprocess_func_list has been fixed in upstream
//build. This Cl upgrades //build to ToT.

In order to do so clang must also be updated. The Wno-undefined-var-template
is only passed if the pinned clang revision isn't 266460, which is the
currently pinned clang revision in chromium. This is there so that the bot
that builds with trunk clang gets this flag, but pinned clang doesn't.

We accidentally pickup the flag since our pinned clang is different from the
Chrome version. So, we must always roll //build and clang together when
changing deps or bad things may happen as there is an implicit dependency
due to compile flags.

BUG=pdfium:106
==========

to

==========
Upgrade build and clang.

The issue with //testing/multiprocess_func_list has been fixed in upstream
//build. This Cl upgrades //build to ToT.

In order to do so clang must also be updated. The Wno-undefined-var-template
is only passed if the pinned clang revision isn't 266460, which is the
currently pinned clang revision in chromium. This is there so that the bot
that builds with trunk clang gets this flag, but pinned clang doesn't.

We accidentally pickup the flag since our pinned clang is different from the
Chrome version. So, we must always roll //build and clang together when
changing deps or bad things may happen as there is an implicit dependency
due to compile flags.

BUG=pdfium:106

Committed:
https://pdfium.googlesource.com/pdfium/+/6b2c4d7d709dbfca0a59ce6310c0941669d0...
==========

[commit-bot: I haz the power, 2016-04-20 17:47:51]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6b2c4d7d709dbfca0a59ce6310c0941669d0...