third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp - Issue 1911473002: Rename transformToRoot:ish names to screenScaleFactorChanged:ish ones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

Issue 1911473002: Rename transformToRoot:ish names to screenScaleFactorChanged:ish ones (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-hiddencontainer-layout-no-xfrmchg

Patch Set: Update comment in LayoutSVGText. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.h ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

index b53b91aba26d2a76dad73ceb8d491fd865e5b25a..93b8116375fcfa49429f2c9339baf9c0f80fc50f 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

@@ -36,7 +36,7 @@ LayoutSVGContainer::LayoutSVGContainer(SVGElement* node)

: LayoutSVGModelObject(node)

, m_objectBoundingBoxValid(false)

, m_needsBoundariesUpdate(true)

- , m_didTransformToRootUpdate(false)

+ , m_didScreenScaleFactorChange(false)

, m_hasNonIsolatedBlendingDescendants(false)

, m_hasNonIsolatedBlendingDescendantsDirty(false)

{

@@ -56,7 +56,7 @@ void LayoutSVGContainer::layout()

// Allow LayoutSVGTransformableContainer to update its transform.

bool updatedTransform = calculateLocalTransform();

- m_didTransformToRootUpdate = updatedTransform || SVGLayoutSupport::transformToRootChanged(parent());

+ m_didScreenScaleFactorChange = updatedTransform || SVGLayoutSupport::screenScaleFactorChanged(parent());

// LayoutSVGViewportContainer needs to set the 'layout size changed' flag.

determineIfLayoutSizeChanged();

@@ -71,7 +71,7 @@ void LayoutSVGContainer::layout()

// the descendants.

bool forceLayoutOfChildren = selfNeedsLayout()

|| (normalChildNeedsLayout() && SVGLayoutSupport::hasFilterResource(*this));

- SVGLayoutSupport::layoutChildren(firstChild(), forceLayoutOfChildren, m_didTransformToRootUpdate, layoutSizeChanged);

+ SVGLayoutSupport::layoutChildren(firstChild(), forceLayoutOfChildren, m_didScreenScaleFactorChange, layoutSizeChanged);

// Invalidate all resources of this client if our layout changed.

if (everHadLayout() && needsLayout())