Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: android_webview/native/aw_gl_functor.cc

Issue 1911433002: Refactor BrowserViewRenderer-RenderThreadManager relationship. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address most comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_gl_functor.cc
diff --git a/android_webview/native/aw_gl_functor.cc b/android_webview/native/aw_gl_functor.cc
index 60e3f05be8978d094df8e2ac460e2dbb9ca36a5f..7a6f0d734d8ff7bee490dc495f65a6bbc0f77a5e 100644
--- a/android_webview/native/aw_gl_functor.cc
+++ b/android_webview/native/aw_gl_functor.cc
@@ -4,7 +4,6 @@
#include "android_webview/native/aw_gl_functor.h"
-#include "android_webview/browser/browser_view_renderer.h"
#include "android_webview/public/browser/draw_gl.h"
#include "content/public/browser/browser_thread.h"
#include "jni/AwGLFunctor_jni.h"
@@ -30,17 +29,10 @@ AwGLFunctor::AwGLFunctor(const JavaObjectWeakGlobalRef& java_ref)
: java_ref_(java_ref),
render_thread_manager_(
this,
- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI)),
- browser_view_renderer_(nullptr) {}
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI)) {}
AwGLFunctor::~AwGLFunctor() {}
-void AwGLFunctor::OnParentDrawConstraintsUpdated() {
- DCHECK_CURRENTLY_ON(BrowserThread::UI);
- if (browser_view_renderer_)
- browser_view_renderer_->OnParentDrawConstraintsUpdated();
-}
-
bool AwGLFunctor::RequestInvokeGL(bool wait_for_completion) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
JNIEnv* env = AttachCurrentThread();
@@ -58,12 +50,6 @@ void AwGLFunctor::DetachFunctorFromView() {
Java_AwGLFunctor_detachFunctorFromView(env, obj.obj());
}
-void AwGLFunctor::SetBrowserViewRenderer(
- BrowserViewRenderer* browser_view_renderer) {
- DCHECK_CURRENTLY_ON(BrowserThread::UI);
- browser_view_renderer_ = browser_view_renderer;
-}
-
void AwGLFunctor::Destroy(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj) {
java_ref_.reset();
« android_webview/browser/test/rendering_test.cc ('K') | « android_webview/native/aw_gl_functor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698