android_webview/browser/render_thread_manager_client.h - Issue 1911433002: Refactor BrowserViewRenderer-RenderThreadManager relationship.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/render_thread_manager_client.h

Issue 1911433002: Refactor BrowserViewRenderer-RenderThreadManager relationship. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address most comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/render_thread_manager.h ('K') | « android_webview/browser/render_thread_manager.cc ('k') | android_webview/browser/test/rendering_test.h » ('j') | android_webview/browser/test/rendering_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/render_thread_manager_client.h

diff --git a/android_webview/browser/render_thread_manager_client.h b/android_webview/browser/render_thread_manager_client.h

index 765e44cc762e9586435b5556d9471c10607fc6be..1d05fd17c3e7dfef305ae3813772224144fa30e0 100644

--- a/android_webview/browser/render_thread_manager_client.h

+++ b/android_webview/browser/render_thread_manager_client.h

@@ -9,8 +9,6 @@ namespace android_webview {

class RenderThreadManagerClient {

public:

- virtual void OnParentDrawConstraintsUpdated() = 0;

// Request DrawGL to be in called AwDrawGLInfo::kModeProcess type.

// |wait_for_completion| will cause the call to block until DrawGL has

// happened. The callback may never be made, and the mode may be promoted to