android_webview/browser/browser_view_renderer_unittest.cc - Issue 1911433002: Refactor BrowserViewRenderer-RenderThreadManager relationship.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/browser_view_renderer_unittest.cc

Issue 1911433002: Refactor BrowserViewRenderer-RenderThreadManager relationship. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address most comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/browser_view_renderer.cc ('K') | « android_webview/browser/browser_view_renderer.cc ('k') | android_webview/browser/compositor_frame_consumer.h » ('j') | android_webview/browser/render_thread_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/browser_view_renderer_unittest.cc

diff --git a/android_webview/browser/browser_view_renderer_unittest.cc b/android_webview/browser/browser_view_renderer_unittest.cc

index 060bee1ffa1e32cb2a745a9eda6d86599db8b0f6..3cec0fb53837143e0e1c429871ea95fa0c1702c9 100644

--- a/android_webview/browser/browser_view_renderer_unittest.cc

+++ b/android_webview/browser/browser_view_renderer_unittest.cc

@@ -8,6 +8,7 @@

#include "android_webview/browser/browser_view_renderer.h"

#include "android_webview/browser/child_frame.h"

+#include "android_webview/browser/render_thread_manager.h"

boliu 2016/04/21 18:14:10 needed?

Tobias Sargeant 2016/04/22 11:42:22 Not strictly. Can't just remove it as is, but mayb

#include "android_webview/browser/test/rendering_test.h"

#include "base/location.h"

#include "base/single_thread_task_runner.h"

@@ -124,7 +125,6 @@ class TestAnimateInAndOutOfScreen : public RenderingTest {

}

void OnParentDrawConstraintsUpdated() override {

- RenderingTest::OnParentDrawConstraintsUpdated();

ParentCompositorDrawConstraints constraints =

render_thread_manager_->GetParentDrawConstraintsOnUI();

switch (on_draw_count_) {