android_webview/browser/test/rendering_test.h - Issue 1911433002: Refactor BrowserViewRenderer-RenderThreadManager relationship.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/test/rendering_test.h

Issue 1911433002: Refactor BrowserViewRenderer-RenderThreadManager relationship. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cope with SetCompositorFrameConsumer(nullptr) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/render_thread_manager.h ('K') | « android_webview/browser/render_thread_manager_client.h ('k') | android_webview/browser/test/rendering_test.cc » ('j') | android_webview/native/aw_gl_functor.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/test/rendering_test.h

diff --git a/android_webview/browser/test/rendering_test.h b/android_webview/browser/test/rendering_test.h

index a186b1ddf78c8d85029ef742372d269ef1b4721e..67287c6726ad3efd070b3ec34b0d4544fe2a0b4c 100644

--- a/android_webview/browser/test/rendering_test.h

+++ b/android_webview/browser/test/rendering_test.h

@@ -51,7 +51,6 @@ class RenderingTest : public testing::Test,

const gfx::Vector2dF& overscroll_velocity) override {}

// RenderThreadManagerClient overrides.

- void OnParentDrawConstraintsUpdated() override;

bool RequestInvokeGL(bool wait_for_completion) override;

void DetachFunctorFromView() override;

@@ -66,6 +65,8 @@ class RenderingTest : public testing::Test,

AwDrawGLInfo* draw_info) override;

void DidDrawOnRT(RenderThreadManager* functor) override {}

+ virtual void OnParentDrawConstraintsUpdated() {}

protected:

RenderingTest();