Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: android_webview/native/aw_gl_functor.h

Issue 1911433002: Refactor BrowserViewRenderer-RenderThreadManager relationship. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cope with SetCompositorFrameConsumer(nullptr) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_NATIVE_AW_GL_FUNCTOR_H_ 5 #ifndef ANDROID_WEBVIEW_NATIVE_AW_GL_FUNCTOR_H_
6 #define ANDROID_WEBVIEW_NATIVE_AW_GL_FUNCTOR_H_ 6 #define ANDROID_WEBVIEW_NATIVE_AW_GL_FUNCTOR_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "android_webview/browser/compositor_frame_consumer.h"
11 #include "android_webview/browser/compositor_frame_producer.h"
boliu 2016/04/21 17:05:40 don't need producer
Tobias Sargeant 2016/04/21 17:48:27 Done.
10 #include "android_webview/browser/render_thread_manager.h" 12 #include "android_webview/browser/render_thread_manager.h"
11 #include "android_webview/browser/render_thread_manager_client.h" 13 #include "android_webview/browser/render_thread_manager_client.h"
12 #include "base/android/jni_weak_ref.h" 14 #include "base/android/jni_weak_ref.h"
13 15
14 namespace android_webview { 16 namespace android_webview {
15 17
16 class BrowserViewRenderer;
17
18 class AwGLFunctor : public RenderThreadManagerClient { 18 class AwGLFunctor : public RenderThreadManagerClient {
19 public: 19 public:
20 void OnParentDrawConstraintsUpdated() override;
21 bool RequestInvokeGL(bool wait_for_completion) override; 20 bool RequestInvokeGL(bool wait_for_completion) override;
22 void DetachFunctorFromView() override; 21 void DetachFunctorFromView() override;
23 22
24 AwGLFunctor(const JavaObjectWeakGlobalRef& java_ref); 23 AwGLFunctor(const JavaObjectWeakGlobalRef& java_ref);
25 ~AwGLFunctor() override; 24 ~AwGLFunctor() override;
26 25
27 void SetBrowserViewRenderer(BrowserViewRenderer* browser_view_renderer);
28
29 void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj); 26 void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
30 void DeleteHardwareRenderer(JNIEnv* env, 27 void DeleteHardwareRenderer(JNIEnv* env,
31 const base::android::JavaParamRef<jobject>& obj); 28 const base::android::JavaParamRef<jobject>& obj);
32 jlong GetAwDrawGLViewContext(JNIEnv* env, 29 jlong GetAwDrawGLViewContext(JNIEnv* env,
33 const base::android::JavaParamRef<jobject>& obj); 30 const base::android::JavaParamRef<jobject>& obj);
34 jlong GetAwDrawGLFunction(JNIEnv* env, 31 jlong GetAwDrawGLFunction(JNIEnv* env,
35 const base::android::JavaParamRef<jobject>& obj); 32 const base::android::JavaParamRef<jobject>& obj);
36 33
37 RenderThreadManager* GetRenderThreadManager() { 34 CompositorFrameConsumer* GetCompositorFrameConsumer() {
38 return &render_thread_manager_; 35 return static_cast<CompositorFrameConsumer*>(&render_thread_manager_);
boliu 2016/04/21 17:05:40 huh? why does this need to be a cast?
Tobias Sargeant 2016/04/21 17:48:27 Doesn't. Removed.
39 } 36 }
40 37
41 private: 38 private:
42 JavaObjectWeakGlobalRef java_ref_; 39 JavaObjectWeakGlobalRef java_ref_;
43 RenderThreadManager render_thread_manager_; 40 RenderThreadManager render_thread_manager_;
44 BrowserViewRenderer* browser_view_renderer_;
45 }; 41 };
46 42
47 bool RegisterAwGLFunctor(JNIEnv* env); 43 bool RegisterAwGLFunctor(JNIEnv* env);
48 44
49 } // namespace android_webview 45 } // namespace android_webview
50 46
51 #endif // ANDROID_WEBVIEW_NATIVE_AW_GL_FUNCTOR_H_ 47 #endif // ANDROID_WEBVIEW_NATIVE_AW_GL_FUNCTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698