Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: android_webview/browser/test/rendering_test.cc

Issue 1911433002: Refactor BrowserViewRenderer-RenderThreadManager relationship. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cope with SetCompositorFrameConsumer(nullptr) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/test/rendering_test.h" 5 #include "android_webview/browser/test/rendering_test.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "android_webview/browser/browser_view_renderer.h" 9 #include "android_webview/browser/browser_view_renderer.h"
10 #include "android_webview/browser/child_frame.h" 10 #include "android_webview/browser/child_frame.h"
11 #include "android_webview/browser/render_thread_manager.h" 11 #include "android_webview/browser/render_thread_manager.h"
12 #include "base/location.h" 12 #include "base/location.h"
13 #include "base/thread_task_runner_handle.h" 13 #include "base/thread_task_runner_handle.h"
14 #include "cc/output/compositor_frame.h" 14 #include "cc/output/compositor_frame.h"
15 #include "content/public/test/test_synchronous_compositor_android.h" 15 #include "content/public/test/test_synchronous_compositor_android.h"
16 16
17 namespace android_webview { 17 namespace android_webview {
18 18
19 namespace {
20 // BrowserViewRenderer subclass used for enabling tests to observe
21 // OnParentDrawConstraintsUpdated.
22 class BrowserViewRendererTest : public BrowserViewRenderer {
23 public:
24 BrowserViewRendererTest(
25 RenderingTest* rendering_test,
26 const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner,
27 bool disable_page_visibility)
28 : BrowserViewRenderer(rendering_test,
29 ui_task_runner,
30 disable_page_visibility),
31 rendering_test_(rendering_test) {}
32
33 void OnParentDrawConstraintsUpdated(
34 CompositorFrameConsumer* compositor_frame_consumer) override {
35 BrowserViewRenderer::OnParentDrawConstraintsUpdated(
36 compositor_frame_consumer);
37 rendering_test_->OnParentDrawConstraintsUpdated();
38 }
39
40 private:
41 RenderingTest* rendering_test_;
42 };
43 }
44
19 RenderingTest::RenderingTest() : message_loop_(new base::MessageLoop) { 45 RenderingTest::RenderingTest() : message_loop_(new base::MessageLoop) {
20 ui_task_runner_ = base::ThreadTaskRunnerHandle::Get(); 46 ui_task_runner_ = base::ThreadTaskRunnerHandle::Get();
21 } 47 }
22 48
23 RenderingTest::~RenderingTest() { 49 RenderingTest::~RenderingTest() {
24 if (window_.get()) 50 if (window_.get())
25 window_->Detach(); 51 window_->Detach();
26 } 52 }
27 53
28 void RenderingTest::SetUpTestHarness() { 54 void RenderingTest::SetUpTestHarness() {
29 DCHECK(!browser_view_renderer_.get()); 55 DCHECK(!browser_view_renderer_.get());
30 DCHECK(!render_thread_manager_.get()); 56 DCHECK(!render_thread_manager_.get());
31 render_thread_manager_.reset( 57 render_thread_manager_.reset(
32 new RenderThreadManager(this, base::ThreadTaskRunnerHandle::Get())); 58 new RenderThreadManager(this, base::ThreadTaskRunnerHandle::Get()));
33 browser_view_renderer_.reset(new BrowserViewRenderer( 59 browser_view_renderer_.reset(new BrowserViewRendererTest(
34 this, base::ThreadTaskRunnerHandle::Get(), false)); 60 this, base::ThreadTaskRunnerHandle::Get(), false));
35 browser_view_renderer_->SetRenderThreadManager(render_thread_manager_.get()); 61 browser_view_renderer_->SetCompositorFrameConsumer(
62 render_thread_manager_.get());
36 InitializeCompositor(); 63 InitializeCompositor();
37 Attach(); 64 Attach();
38 } 65 }
39 66
40 void RenderingTest::InitializeCompositor() { 67 void RenderingTest::InitializeCompositor() {
41 DCHECK(!compositor_.get()); 68 DCHECK(!compositor_.get());
42 DCHECK(browser_view_renderer_.get()); 69 DCHECK(browser_view_renderer_.get());
43 compositor_.reset(new content::TestSynchronousCompositor); 70 compositor_.reset(new content::TestSynchronousCompositor);
44 compositor_->SetClient(browser_view_renderer_.get()); 71 compositor_->SetClient(browser_view_renderer_.get());
45 } 72 }
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 } 134 }
108 135
109 void RenderingTest::OnNewPicture() { 136 void RenderingTest::OnNewPicture() {
110 } 137 }
111 138
112 void RenderingTest::PostInvalidate() { 139 void RenderingTest::PostInvalidate() {
113 if (window_) 140 if (window_)
114 window_->PostInvalidate(); 141 window_->PostInvalidate();
115 } 142 }
116 143
117 void RenderingTest::OnParentDrawConstraintsUpdated() {
118 browser_view_renderer_->OnParentDrawConstraintsUpdated();
119 }
120
121 void RenderingTest::DetachFunctorFromView() { 144 void RenderingTest::DetachFunctorFromView() {
122 } 145 }
123 146
124 gfx::Point RenderingTest::GetLocationOnScreen() { 147 gfx::Point RenderingTest::GetLocationOnScreen() {
125 return gfx::Point(); 148 return gfx::Point();
126 } 149 }
127 150
128 } // namespace android_webview 151 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698