Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1911403004: Make SkDrawable an SkFlattenable (Closed)

Created:
4 years, 8 months ago by msarett
Modified:
4 years, 8 months ago
Reviewers:
mtklein, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -2 lines) Patch
M include/core/SkDrawable.h View 3 chunks +6 lines, -2 lines 0 comments Download
M include/core/SkFlattenable.h View 1 chunk +1 line, -0 lines 0 comments Download
A tests/FlattenDrawableTest.cpp View 1 chunk +281 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
msarett
Here's step 2 on the path to serializing drawables.
4 years, 8 months ago (2016-04-22 20:35:12 UTC) #4
reed1
lgtm
4 years, 8 months ago (2016-04-23 10:54:34 UTC) #5
mtklein
lgtm too!
4 years, 8 months ago (2016-04-23 14:29:08 UTC) #6
djsollen
just want to get in on the lgtm party! Thanks for spending the time to ...
4 years, 8 months ago (2016-04-24 02:23:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911403004/1
4 years, 8 months ago (2016-04-25 13:26:57 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 13:40:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/edf7fcd8b9e339800edb61ae422f8b6c1b77c3e8

Powered by Google App Engine
This is Rietveld 408576698