Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h

Issue 1911403003: [chrome.displaySource] Move video stream info creation to encoders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Replace CreateElementaryStreamDescriptors member function with a member variable Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h
diff --git a/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h b/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h
index d992d4742f9ce0c668d638519f7e85ad9a6e520c..7f14e8ae0513dfaa22c996eb0e761350354235ae 100644
--- a/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h
+++ b/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h
@@ -5,6 +5,8 @@
#ifndef EXTENSIONS_RENDERER_API_DISPLAY_SOURCE_WIFI_DISPLAY_WIFI_DISPLAY_VIDEO_ENCODER_H_
#define EXTENSIONS_RENDERER_API_DISPLAY_SOURCE_WIFI_DISPLAY_WIFI_DISPLAY_VIDEO_ENCODER_H_
+#include <vector>
+
#include "base/memory/shared_memory.h"
#include "extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.h"
#include "media/base/video_frame.h"
@@ -13,6 +15,8 @@
namespace extensions {
+class WiFiDisplayElementaryStreamDescriptor;
+
using WiFiDisplayEncodedFrame = WiFiDisplayEncodedUnit;
// This interface represents H.264 video encoder used by the
@@ -54,6 +58,9 @@ class WiFiDisplayVideoEncoder : public WiFiDisplayMediaEncoder {
static void Create(const InitParameters& params,
const VideoEncoderCallback& encoder_callback);
+ // WiFiDisplayMediaEncoder
+ WiFiDisplayElementaryStreamInfo CreateElementaryStreamInfo() const final;
+
// Encodes the given raw frame. The resulting encoded frame is passed
// as an |encoded_callback|'s argument which is set via 'SetCallbacks'
// method.
@@ -79,6 +86,7 @@ class WiFiDisplayVideoEncoder : public WiFiDisplayMediaEncoder {
base::TimeTicks reference_time,
bool send_idr) = 0;
+ std::vector<WiFiDisplayElementaryStreamDescriptor> descriptors_;
scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_;
bool send_idr_;
};

Powered by Google App Engine
This is Rietveld 408576698