Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 19114006: Remove dwm function because it is going away in windows 8.1 (Closed)

Created:
7 years, 5 months ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove dwm function because it is going away in windows 8.1 I am guessing that this does nothing perf-wise, certainly resize wise I don't observe any improvement wrt to not having it. On the even more speculative angle (pun intended) it might be interfering with flip_ex present experiments. TBR=jam TEST=none BUG=224764 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212308

Patch Set 1 #

Patch Set 2 : fixing telemetry test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -25 lines) Patch
M content/browser/renderer_host/render_widget_host_view_win.cc View 4 chunks +4 lines, -25 lines 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
cpu_(ooo_6.6-7.5)
do we need Nat to opinionate in this review?
7 years, 5 months ago (2013-07-12 23:05:05 UTC) #1
cpu_(ooo_6.6-7.5)
also it seems there is a test failing GpuTabTest.testScreenshot: Traceback (most recent call last): File ...
7 years, 5 months ago (2013-07-14 19:30:18 UTC) #2
apatrick_chromium
I think this isn't needed. As I remember it was a speculative attempt to fix ...
7 years, 5 months ago (2013-07-15 20:02:50 UTC) #3
cpu_(ooo_6.6-7.5)
+Nat for the telemetry fix.
7 years, 5 months ago (2013-07-16 22:42:44 UTC) #4
nduca
lgtm thanks
7 years, 5 months ago (2013-07-16 23:00:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/19114006/7001
7 years, 5 months ago (2013-07-16 23:41:09 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=15570
7 years, 5 months ago (2013-07-17 03:01:53 UTC) #7
cpu_(ooo_6.6-7.5)
john can I get owner's rs ?
7 years, 5 months ago (2013-07-17 20:07:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/19114006/7001
7 years, 5 months ago (2013-07-17 23:25:14 UTC) #9
jam
lgtm
7 years, 5 months ago (2013-07-17 23:30:50 UTC) #10
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 09:41:17 UTC) #11
Message was sent while issue was closed.
Change committed as 212308

Powered by Google App Engine
This is Rietveld 408576698