Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1911373002: Articulate the cancel behavior in the WebTouchEvent. (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Articulate the cancel behavior in the WebTouchEvent. Change the cancelable flag to be an enumeration so that we can determine if it is blocking or non-blocking and the reason. Wheel events will add this flag in a follow up CL. BUG=601661 Review URL: https://codereview.chromium.org/1888163003 Cr-Commit-Position: refs/heads/master@{#388585} (cherry picked from commit afb8f54b782055923cadd711452c2448f3f7b5b4) Committed: https://chromium.googlesource.com/chromium/src/+/0d6939cf25aa552bc77692aabe894ba5ba0bd6de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -96 lines) Patch
M components/test_runner/event_sender.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 27 chunks +41 lines, -41 lines 0 comments Download
M content/common/input/web_input_event_traits.cc View 4 chunks +35 lines, -3 lines 0 comments Download
M content/common/input/web_input_event_traits_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M content/common/input/web_touch_event_traits.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/input/main_thread_event_queue.cc View 1 chunk +18 lines, -7 lines 0 comments Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 4 chunks +32 lines, -19 lines 0 comments Download
M content/renderer/render_widget_unittest.cc View 11 chunks +102 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PlatformEvent.h View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformTouchEvent.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 3 chunks +16 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TouchActionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 6 chunks +16 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebInputEvent.h View 3 chunks +21 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/blink_event_util.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 8 months ago (2016-04-22 13:57:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0d6939cf25aa552bc77692aabe894ba5ba0bd6de.

Powered by Google App Engine
This is Rietveld 408576698