Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 191133003: In tests call ImeAdapter from UI thread only. (Closed)

Created:
6 years, 9 months ago by aurimas (slooooooooow)
Modified:
6 years, 9 months ago
Reviewers:
Ted C, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

In tests call ImeAdapter from UI thread only. BUG=None R=tedchoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -17 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/ClipboardTest.java View 3 chunks +22 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 5 chunks +52 lines, -7 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java View 5 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
aurimas (slooooooooow)
Here is the patch that should allow you to land yours. PTAL
6 years, 9 months ago (2014-03-07 18:51:56 UTC) #1
jam
On 2014/03/07 18:51:56, aurimas wrote: > Here is the patch that should allow you to ...
6 years, 9 months ago (2014-03-07 19:08:06 UTC) #2
aurimas (slooooooooow)
Hey Ted, PTAL. Aurimas
6 years, 9 months ago (2014-03-07 19:10:17 UTC) #3
Ted C
lgtm
6 years, 9 months ago (2014-03-07 19:14:30 UTC) #4
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-07 20:22:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/191133003/1
6 years, 9 months ago (2014-03-07 20:34:59 UTC) #6
aurimas (slooooooooow)
The CQ bit was unchecked by aurimas@chromium.org
6 years, 9 months ago (2014-03-07 23:57:11 UTC) #7
aurimas (slooooooooow)
6 years, 9 months ago (2014-03-07 23:59:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r255718 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698