Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Unified Diff: src/wasm/wasm-opcodes.h

Issue 1911313002: Pass debug name as Vector instead of const char* (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-offset-table-1
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-opcodes.h
diff --git a/src/wasm/wasm-opcodes.h b/src/wasm/wasm-opcodes.h
index b75e70c0dc26db7dd9a991265f649620c02d2e36..184e32617bcf159558d7216059f7e9b040d50519 100644
--- a/src/wasm/wasm-opcodes.h
+++ b/src/wasm/wasm-opcodes.h
@@ -52,6 +52,8 @@ std::ostream& operator<<(std::ostream& os, const FunctionSig& function);
struct WasmName {
const char* name;
uint32_t length;
+ // TODO(clemensh): Remove whole WasmName, replace by Vector<const char>
titzer 2016/04/22 11:46:30 This should be inline, to prevent a proliferation
Clemens Hammacher 2016/04/22 13:47:54 I will remove the whole WasmName in https://codere
+ Vector<const char> toVec() const { return Vector<const char>(name, length); }
};
// TODO(titzer): Renumber all the opcodes to fill in holes.
« src/vector.h ('K') | « src/vector.h ('k') | test/cctest/compiler/codegen-tester.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698