Pass debug name as Vector instead of const char*

src/vector.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_VECTOR_H_
 #define V8_VECTOR_H_
 
 #include <string.h>
 #include <algorithm>
 
 #include "src/allocation.h"
 #include "src/checks.h"
 #include "src/globals.h"
 
 namespace v8 {
 namespace internal {
 
 
 template <typename T>
 class Vector {
  public:
   Vector() : start_(NULL), length_(0) {}
   Vector(T* data, int length) : start_(data), length_(length) {
     DCHECK(length == 0 || (length > 0 && data != NULL));
   }
 
+  template <int N>
+  explicit Vector(T (&arr)[N]) : start_(arr), length_(N) {}
+
   static Vector<T> New(int length) {
     return Vector<T>(NewArray<T>(length), length);
   }
 
   // Returns a vector using the same backing storage as this one,
   // spanning from and including 'from', to but not including 'to'.
   Vector<T> SubVector(int from, int to) {
     DCHECK(0 <= from);
     SLOW_DCHECK(from < to);
     SLOW_DCHECK(static_cast<unsigned>(to) <= static_cast<unsigned>(length_));
@@ skipping 157 matching lines @@
 
 inline Vector<char> MutableCStrVector(char* data) {
   return Vector<char>(data, StrLength(data));
 }
 
 inline Vector<char> MutableCStrVector(char* data, int max) {
   int length = StrLength(data);
   return Vector<char>(data, (length < max) ? length : max);
 }
 
+template <typename T, int N>

[titzer, 2016/04/22 11:46:30]

Since this is only ever used for C strings (now), I'd suggest:

inline Vector<const char> CStrVector(const char*[N])

[Clemens Hammacher, 2016/04/22 13:47:54]

CStrVector is already there, but it takes a const char*, and computes the string
length itself; this is unnecessary in many cases.

ArrayVector was meant to be a type-safe generalization of STATIC_CHAR_VECTOR,
and there are indeed 28 places where a pattern like 'Vector<T> vec(buffer,
arraysize(buffer))' is used, where T is char, const char* or HValue*.
Is it desirable to refactor such code, in the belief that ArrayVector is much
nicer?

[titzer, 2016/04/22 13:51:45]

Yeah, I'd rather just make a small addition now and fork off refactoring of the
other places in V8 in another CL. So you can just add a variant of CStrVector if
its possible. I find it reads nicer at call sites to see
CStrVector("somestring") instead of ArrayVector("somestring"): again,
communicating intent.

+inline Vector<T> ArrayVector(T (&arr)[N]) {
+  return Vector<T>(arr);
+}
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_VECTOR_H_