Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 1911243004: Revert of Generate Android .isolate files used for test()s (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, mikecase+watch_chromium.org, android-webview-reviews_chromium.org, jbudorick+watch_chromium.org, bengr, dgn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Generate Android .isolate files used for test()s (patchset #4 id:60001 of https://codereview.chromium.org/1904823003/ ) Reason for revert: WebKit Android (Nexus 4) blink_heap_unittests failing: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/45633 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/45633/steps/blink_heap_unittests/logs/stdio Original issue's description: > Generate Android .isolate files used for test()s > > Tests use write_runtime_deps to have GN write out all runtime_deps, then > use a new script "generate_isolate.py" to filter the files and create a > .isolate. > > TBR=vollick > BUG=589318 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=sgurun@chromium.org,vollick@chromium.org,dpranke@chromium.org,jochen@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=589318 Committed: https://crrev.com/7aba779e901e0901b98a425193f7b829ba29fa1d Cr-Commit-Position: refs/heads/master@{#389134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -238 lines) Patch
M android_webview/test/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +1 line, -3 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 2 chunks +1 line, -3 lines 0 comments Download
M build/android/pylib/utils/isolator.py View 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/android/internal_rules.gni View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/BUILD.gn View 1 chunk +3 lines, -5 lines 0 comments Download
D testing/generate_isolate.py View 1 chunk +0 lines, -114 lines 0 comments Download
M testing/test.gni View 6 chunks +5 lines, -101 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
apacible
Created Revert of Generate Android .isolate files used for test()s
4 years, 8 months ago (2016-04-22 16:30:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911243004/1
4 years, 8 months ago (2016-04-22 16:31:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911243004/1
4 years, 8 months ago (2016-04-22 16:31:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 16:32:25 UTC) #5
agrieve
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1914573002/ by agrieve@chromium.org. ...
4 years, 8 months ago (2016-04-22 16:58:49 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:48:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7aba779e901e0901b98a425193f7b829ba29fa1d
Cr-Commit-Position: refs/heads/master@{#389134}

Powered by Google App Engine
This is Rietveld 408576698