Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1911243002:
DevTools: Do not record nested FunctionCall events (Closed)
|
Created:
4 years, 8 months ago by alph Modified:
4 years, 8 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Do not record nested FunctionCall events.
BUG=593991
Committed: https://crrev.com/0d984b7d76cd1945834793344888127c16879ee7
Cr-Commit-Position: refs/heads/master@{#389664}
Patch Set 1 #Patch Set 2 : make the event disabled by default. #Patch Set 3 : nuke nested FunctionCall events #Patch Set 4 : rebaseline #
Messages
Total messages: 35 (16 generated)
alph@chromium.org changed reviewers: + caseq@chromium.org
Description was changed from ========== DevTools: do not record FunctionCall event when sampling is enabled. BUG=593991 ========== to ========== DevTools: Do not record nested FunctionCall events. BUG=593991 ==========
ptal
The CQ bit was checked by caseq@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911243002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
alph@chromium.org changed reviewers: + pfeldman@chromium.org
On 2016/04/22 20:39:48, alph wrote: Why is nested scope less important than top level?
Description was changed from ========== DevTools: Do not record nested FunctionCall events. BUG=593991 ========== to ========== DevTools: Do not record FunctionCall events. BUG=593991 ==========
On 2016/04/22 20:48:35, pfeldman wrote: > On 2016/04/22 20:39:48, alph wrote: > > Why is nested scope less important than top level? Top level is not that frequent. Anyway I nuked all the FunctionCall events. ptal.
lgtm
https://codereview.chromium.org/1911243002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/inspector/tracing/timeline-timer-fired-from-eval-call-site-expected.txt (left): https://codereview.chromium.org/1911243002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/inspector/tracing/timeline-timer-fired-from-eval-call-site-expected.txt:4: TimerFire fromEval.js:2 On second thought, let's not go there. 'Tis a silly place.
Patchset #4 (id:60001) has been deleted
On 2016/04/22 20:48:35, pfeldman wrote: > On 2016/04/22 20:39:48, alph wrote: > > Why is nested scope less important than top level? We get location info from the topmost ones, e.g. for TimerFire events.
Description was changed from ========== DevTools: Do not record FunctionCall events. BUG=593991 ========== to ========== DevTools: Do not record nested FunctionCall events. BUG=593991 ==========
As an intermediate solution, it lgtm
On 2016/04/25 21:58:45, pfeldman wrote: > As an intermediate solution, it lgtm Are we clear on what the "right" solution is?
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911243002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by alph@chromium.org
The CQ bit was unchecked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911243002/40001
The CQ bit was checked by alph@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org, pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/1911243002/#ps80001 (title: "rebaseline")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911243002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911243002/80001
Message was sent while issue was closed.
Description was changed from ========== DevTools: Do not record nested FunctionCall events. BUG=593991 ========== to ========== DevTools: Do not record nested FunctionCall events. BUG=593991 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: Do not record nested FunctionCall events. BUG=593991 ========== to ========== DevTools: Do not record nested FunctionCall events. BUG=593991 Committed: https://crrev.com/0d984b7d76cd1945834793344888127c16879ee7 Cr-Commit-Position: refs/heads/master@{#389664} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0d984b7d76cd1945834793344888127c16879ee7 Cr-Commit-Position: refs/heads/master@{#389664} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
