Update changelog for event changes in dart:html

Update changelog for event changes in dart:html, etc in 1.16

Closes https://github.com/dart-lang/sdk/issues/25970

R=alanknight@google.com, terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/fd08dae06332bee3a45746dc51f5af4cb5ca3425

[kevmoo, 2016-04-22 03:50:00]

Description was changed from

==========
Update changelog for event changes in dart:html
==========

to

==========
Update changelog for event changes in dart:html, etc in 1.16

Closes https://github.com/dart-lang/sdk/issues/25970
==========

[kevmoo, 2016-04-22 03:50:00]

kevmoo@google.com changed reviewers:
+ mit@google.com, terry@google.com

[kevmoo, 2016-04-22 22:30:34]

kevmoo@google.com changed reviewers:
+ alanknight@google.com

[kevmoo, 2016-04-22 22:30:34]

ping?

[Alan Knight, 2016-04-25 17:09:09]

lgtm with nits

https://codereview.chromium.org/1911213002/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1911213002/diff/20001/CHANGELOG.md#newcode19
CHANGELOG.md:19: There have been a number of **BREAKING** changes to align APIs
with recent changes Chrome.
"in Chrome"

Also line length

https://codereview.chromium.org/1911213002/diff/20001/CHANGELOG.md#newcode20
CHANGELOG.md:20: These including:
include:

[terry, 2016-04-25 17:56:11]

https://codereview.chromium.org/1911213002/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1911213002/diff/20001/CHANGELOG.md#newcode37
CHANGELOG.md:37: 
You'll want to add these too:

1. Chrome's ShadowRoot interface no longer has the method
getElementsByClassName, e.g.,

  getElementsByClassName('clazz')

should become:

  querySelectorAll('.clazz')


2. Mention the @JS() syntax required at the library directive (if the library
has any @JS annotations).

Here's the email I sent out when the change was made.

However, 1.16 will expose a change in how JS Interop is used.  For performance
reasons, an additional requirement is needed to use JS Interop.  Any Dart file
that uses @JS annotations on declarations (top-level functions, classes or class
members) to interop with Javascript code will require that the file have the
annotation @JS() on a ibrary directive  e.g.,

@JS()
library my_library;

The analyzer will enforce this by generating the error:

The @JS() annotation can only be used if it is also declared on the library
directive.

If a file that is a part of a library the library that uses the part should have
the @JS() annotation e.g.,

library_1.dart

@JS()
library library_1;

import 'package:js/js.dart';

part 'part_1.dart';

part_1.dart

part of library_1;

@JS("frameworkStabilizers")
external List<FrameworkStabilizer> get frameworkStabilizers;

If a main Dart file uses interop e.g.

import 'package:js/js.dart';

@JS()
external Function get doubleValue;

main() {
 ...
}

Then at the top you this Dart file/script add following lines (name used for
library can be any valid name):

@JS()
library main1;

If your library already has a JS module e.g.,

@JS('array.utils')
library my_library;

Then your library will work without any additional changes, the @JS annotation
exist.

[kevmoo, 2016-04-25 21:31:10]

PTAL

https://codereview.chromium.org/1911213002/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1911213002/diff/20001/CHANGELOG.md#newcode19
CHANGELOG.md:19: There have been a number of **BREAKING** changes to align APIs
with recent changes Chrome.
On 2016/04/25 17:09:09, Alan Knight wrote:
> "in Chrome"
> 
> Also line length

Done.

https://codereview.chromium.org/1911213002/diff/20001/CHANGELOG.md#newcode20
CHANGELOG.md:20: These including:
On 2016/04/25 17:09:09, Alan Knight wrote:
> include:

Done.

https://codereview.chromium.org/1911213002/diff/20001/CHANGELOG.md#newcode37
CHANGELOG.md:37: 
On 2016/04/25 17:56:11, terry wrote:
> You'll want to add these too:
> 
> 1. Chrome's ShadowRoot interface no longer has the method
> getElementsByClassName, e.g.,
> 
>   getElementsByClassName('clazz')
> 
> should become:
> 
>   querySelectorAll('.clazz')
> 
> 
> 2. Mention the @JS() syntax required at the library directive (if the library
> has any @JS annotations).
> 
> Here's the email I sent out when the change was made.
> 
> However, 1.16 will expose a change in how JS Interop is used.  For performance
> reasons, an additional requirement is needed to use JS Interop.  Any Dart file
> that uses @JS annotations on declarations (top-level functions, classes or
class
> members) to interop with Javascript code will require that the file have the
> annotation @JS() on a ibrary directive  e.g.,
> 
> @JS()
> library my_library;
> 
> The analyzer will enforce this by generating the error:
> 
> The @JS() annotation can only be used if it is also declared on the library
> directive.
> 
> If a file that is a part of a library the library that uses the part should
have
> the @JS() annotation e.g.,
> 
> library_1.dart
> 
> @JS()
> library library_1;
> 
> import 'package:js/js.dart';
> 
> part 'part_1.dart';
> 
> part_1.dart
> 
> part of library_1;
> 
> @JS("frameworkStabilizers")
> external List<FrameworkStabilizer> get frameworkStabilizers;
> 
> If a main Dart file uses interop e.g.
> 
> import 'package:js/js.dart';
> 
> @JS()
> external Function get doubleValue;
> 
> main() {
>  ...
> }
> 
> Then at the top you this Dart file/script add following lines (name used for
> library can be any valid name):
> 
> @JS()
> library main1;
> 
> If your library already has a JS module e.g.,
> 
> @JS('array.utils')
> library my_library;
> 
> Then your library will work without any additional changes, the @JS annotation
> exist.

Done.

[terry, 2016-04-25 21:37:09]

lgtm

[kevmoo, 2016-04-25 21:42:28]

Description was changed from

==========
Update changelog for event changes in dart:html, etc in 1.16

Closes https://github.com/dart-lang/sdk/issues/25970
==========

to

==========
Update changelog for event changes in dart:html, etc in 1.16

Closes https://github.com/dart-lang/sdk/issues/25970

R=alanknight@google.com, terry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fd08dae06332bee3a45746dc51f5af4cb5ca3425
==========

[kevmoo, 2016-04-25 21:42:30]

Committed patchset #4 (id:60001) manually as
fd08dae06332bee3a45746dc51f5af4cb5ca3425 (presubmit successful).