Remove connection from AudioParamHandler to AudioContext.

Remove connection from AudioParamHandler to AudioContext.

This removes the connection from AudioParamHandler and
AudioParamTimeline to AudioContext.  This is achieved by having
AudioParamHandler and AudioParamTimeline access the
AudioDestinationHandler instead of the AudioContext.
AudioDestinationHandler has the necessary sampleRate(),
currentSampleFrame(), and currentTime() methods that AudioParamHandler
and AudioParamTimeline need.

BUG=605726
TEST=none

Committed: https://crrev.com/f1afe5ba38f00c14f9982c8d0b3afd598865f411
Cr-Commit-Position: refs/heads/master@{#390179}

[Raymond Toy, 2016-04-25 15:55:52]

rtoy@chromium.org changed reviewers:
+ tkent@chromium.org

[Raymond Toy, 2016-04-25 15:55:53]

PTAL at the general approach.  I don't think there's any cycle between the
AudioDestinationHandler and AudioParamHandler.

[Raymond Toy, 2016-04-25 15:56:08]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[hongchan, 2016-04-25 16:58:18]

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp (right):

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:305: float
AudioParamTimeline::valueForContextTime(AudioDestinationHandler* context, float
defaultValue, bool& hasValue)
context => destinationHandler

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:307:
ASSERT(context);
Ditto from here and on.

[tkent, 2016-04-25 23:10:09]

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParam.h (right):

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParam.h:64:
AudioDestinationHandler* context() const;
Maybe we'd like to rename the function.

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParam.h:129:
AudioDestinationHandler& m_destination;
Is it safe to hold a raw reference of AudioDestinationHandler?  Can we make this
RefPtr<AudioDestinationHandler>?

[Raymond Toy, 2016-04-25 23:15:33]

On 2016/04/25 23:10:09, tkent wrote:
>
https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/webaudio/AudioParam.h (right):
> 
>
https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/webaudio/AudioParam.h:64:
> AudioDestinationHandler* context() const;
> Maybe we'd like to rename the function.
> 
>
https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/webaudio/AudioParam.h:129:
> AudioDestinationHandler& m_destination;
> Is it safe to hold a raw reference of AudioDestinationHandler?  Can we make
this
> RefPtr<AudioDestinationHandler>?

Sorry about the names. I just wanted to sketch out the approach, without
changing the names yet.

Yes, I think it should be a RefPtr. Need to think about what happens when this
is done because that would mean the AudioDestination handler can't go away until
all of the AudioParams go away.  I think this is ok.

[Raymond Toy, 2016-04-26 16:37:42]

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParam.h (right):

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParam.h:64:
AudioDestinationHandler* context() const;
On 2016/04/25 23:10:09, tkent wrote:
> Maybe we'd like to rename the function.

Renamed to audioDestination().

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParam.h:129:
AudioDestinationHandler& m_destination;
On 2016/04/25 23:10:09, tkent wrote:
> Is it safe to hold a raw reference of AudioDestinationHandler?  Can we make
this
> RefPtr<AudioDestinationHandler>?

Done.

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp (right):

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:305: float
AudioParamTimeline::valueForContextTime(AudioDestinationHandler* context, float
defaultValue, bool& hasValue)
On 2016/04/25 16:58:18, hoch wrote:
> context => destinationHandler

audioDestination instead of destinationHandler.

https://codereview.chromium.org/1911133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:307:
ASSERT(context);
On 2016/04/25 16:58:18, hoch wrote:
> Ditto from here and on.

Done.

[hongchan, 2016-04-26 17:04:01]

Nits on renaming.

https://codereview.chromium.org/1911133002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParam.cpp (right):

https://codereview.chromium.org/1911133002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParam.cpp:40: return
*m_destination;
Perhaps:
audioDestination() => destinationHandler();
m_destination => m_destinationHandler;

Here and on.

https://codereview.chromium.org/1911133002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParam.h (right):

https://codereview.chromium.org/1911133002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParam.h:64:
AudioDestinationHandler& audioDestination() const;
But why is this named as destination when it refers the handler? I think
destinationHandler() is better, but it's up to you.

https://codereview.chromium.org/1911133002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParam.h:129:
RefPtr<AudioDestinationHandler> m_destination;
Perhaps: m_destination => m_destinationHandler

[tkent, 2016-04-26 22:46:37]

lgtm

[Raymond Toy, 2016-04-27 15:20:00]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-04-27 15:20:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911133002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911133002/80001

[commit-bot: I haz the power, 2016-04-27 18:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 18:46:18]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2016-04-27 19:51:07]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-04-27 19:51:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911133002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911133002/80001

[commit-bot: I haz the power, 2016-04-27 20:54:02]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-30 17:12:54]

Patchset 5 (id:??) landed as
https://crrev.com/f1afe5ba38f00c14f9982c8d0b3afd598865f411
Cr-Commit-Position: refs/heads/master@{#390179}

[commit-bot: I haz the power, 2016-04-30 17:51:48]

Description was changed from

==========
Remove connection from AudioParamHandler to AudioContext.

This removes the connection from AudioParamHandler and
AudioParamTimeline to AudioContext.  This is achieved by having
AudioParamHandler and AudioParamTimeline access the
AudioDestinationHandler instead of the AudioContext.
AudioDestinationHandler has the necessary sampleRate(),
currentSampleFrame(), and currentTime() methods that AudioParamHandler
and AudioParamTimeline need.

BUG=605726
TEST=none
==========

to

==========
Remove connection from AudioParamHandler to AudioContext.

This removes the connection from AudioParamHandler and
AudioParamTimeline to AudioContext.  This is achieved by having
AudioParamHandler and AudioParamTimeline access the
AudioDestinationHandler instead of the AudioContext.
AudioDestinationHandler has the necessary sampleRate(),
currentSampleFrame(), and currentTime() methods that AudioParamHandler
and AudioParamTimeline need.

BUG=605726
TEST=none

Committed: https://crrev.com/f1afe5ba38f00c14f9982c8d0b3afd598865f411
Cr-Commit-Position: refs/heads/master@{#390179}
==========