Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1911123002: Pass through 'sbix' table

Created:
4 years, 8 months ago by jungshik at Google
Modified:
3 years, 11 months ago
Reviewers:
drott, behdad_google
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass through 'sbix' table 'sbix' table is used in Apple-style color font. By passing it through, Chrome on Mac, Linux, Chrome OS and Android can use a Apple-style color font when served as a web font. I didn't use |#if !OS(WINDOWS)| (Windows is the only platform where Chrome does not support sbix) following the precedent of other tables. See https://pixelambacht.nl/demo/color-font-test.html BUG=605334 TEST=Layout tests to be added.

Patch Set 1 #

Patch Set 2 : add a layout test with a test sbix font #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 chunks +5 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/text/emoji-sbix-web-font.html View 1 2 chunks +4 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/third_party/FruityGirl/FruityGirl-uni002A-sbix.ttf View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/third_party/FruityGirl/README.chromium View 1 1 chunk +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/opentype/OpenTypeSanitizer.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/ots/src/ots.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
drott
LGTM. Are you planning to follow up on this one?
3 years, 11 months ago (2016-12-28 18:55:18 UTC) #3
behdad_google
3 years, 11 months ago (2016-12-28 19:07:47 UTC) #5
FWIW latest Windows supports sbix, though Blink probably doesn't support that
yet.

Powered by Google App Engine
This is Rietveld 408576698