Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1911093002: Remove incorrect DCHECK in RequestOpenURL. (Closed)

Created:
4 years, 8 months ago by Charlie Reis
Modified:
4 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove incorrect DCHECK in RequestOpenURL. BUG=605055 TEST=Ctrl click any link in a subframe. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/6285aedbb91a0c7895e61975cc5055ae24e11aa0 Cr-Commit-Position: refs/heads/master@{#388948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M content/browser/frame_host/navigator_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A content/test/data/ctrl-click-subframe-link.html View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Charlie Reis
Nasko, can you take a quick look? I'm just removing an invariant that I realized ...
4 years, 8 months ago (2016-04-21 21:39:37 UTC) #3
nasko
LGTM
4 years, 8 months ago (2016-04-21 22:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911093002/1
4 years, 8 months ago (2016-04-21 22:25:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 23:32:57 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:41:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6285aedbb91a0c7895e61975cc5055ae24e11aa0
Cr-Commit-Position: refs/heads/master@{#388948}

Powered by Google App Engine
This is Rietveld 408576698