Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 1911013002: PDF scrolling with wheel gestures (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

PDF scrolling with wheel gestures Scroll gestures may be generated twice, as a plugin may 'resend' them if not fully consumed by the plugin, and they may be generated once again inside the main renderer host. Re-sending of gesture scroll events from the plugin causes double scroll values in PDFs This was more noticable on Windows which uses a larger tick counter (120) vs 53 on Linux. Fix is to not generate gestures inside the plugin container. BUG=604734 Review URL: https://codereview.chromium.org/1898333002 Cr-Commit-Position: refs/heads/master@{#388508} (cherry picked from commit 874feac6c0e08aab52bd08fe33d5daee0ae07fa5) Committed: https://chromium.googlesource.com/chromium/src/+/8960269d9901e0715357ac4a7d092550a6ebb39a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 8 months ago (2016-04-21 20:23:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8960269d9901e0715357ac4a7d092550a6ebb39a.

Powered by Google App Engine
This is Rietveld 408576698