content/test/webkit_support.cc - Issue 191093002: Simplify the user agent code some more since after r255534 it's not affected by the site's URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/webkit_support.cc

Issue 191093002: Simplify the user agent code some more since after r255534 it's not affected by the site's URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/blink_platform_impl.cc ('K') | « content/renderer/service_worker/embedded_worker_dispatcher.cc ('k') | net/url_request/http_user_agent_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/webkit_support.cc

===================================================================

--- content/test/webkit_support.cc (revision 255624)

+++ content/test/webkit_support.cc (working copy)

@@ -18,8 +18,6 @@

#include "third_party/WebKit/public/web/WebRuntimeFeatures.h"

#include "ui/base/resource/resource_bundle.h"

#include "url/url_util.h"

-#include "webkit/common/user_agent/user_agent.h"

-#include "webkit/common/user_agent/user_agent_util.h"

#if defined(OS_ANDROID)

#include "base/android/jni_android.h"

@@ -110,8 +108,6 @@

// at same time.

url_util::Initialize();

test_environment = new TestEnvironment;

- webkit_glue::SetUserAgent(webkit_glue::BuildUserAgentFromProduct(

tfarina 2014/03/07 22:06:07 this would be my only concern on //content changes

- "DumpRenderTree/0.0.0.0"));

scottmg 2014/03/07 21:19:48 Is this going to break blink tests?

jam 2014/03/07 21:34:55 I had searched for this string but didn't find it

jam 2014/03/07 23:13:03 looks like this did break webkit_unit_tests, but t

}

void TearDownTestEnvironment() {