appengine/logdog/coordinator/logStream.go - Issue 1910923002: LogDog: Add project namespace to service endpoint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/logdog/coordinator/logStream.go

Issue 1910923002: LogDog: Add project namespace to service endpoint. (Closed) Base URL: https://github.com/luci/luci-go@logdog-project-coordinator-backend

Patch Set: Comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/logdog/coordinator/endpoints/services/terminateStream.go ('k') | appengine/logdog/coordinator/logStream_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/logdog/coordinator/logStream.go

diff --git a/appengine/logdog/coordinator/logStream.go b/appengine/logdog/coordinator/logStream.go

index 6a0d63630b768c22671dae53867215ec231be884..ae2b260dac29596449f3b4737483f3d444d6dae4 100644

--- a/appengine/logdog/coordinator/logStream.go

+++ b/appengine/logdog/coordinator/logStream.go

@@ -356,8 +356,8 @@ func (s *LogStream) validateImpl(enforceHashID bool) error {

if err := types.StreamName(s.Name).Validate(); err != nil {

return fmt.Errorf("invalid name: %s", err)

}

- if len(s.Secret) != types.StreamSecretLength {

- return fmt.Errorf("invalid secret length (%d != %d)", len(s.Secret), types.StreamSecretLength)

+ if err := types.PrefixSecret(s.Secret).Validate(); err != nil {

+ return fmt.Errorf("invalid prefix secret: %s", err)

}

if s.ContentType == "" {

return errors.New("empty content type")