Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3499)

Unified Diff: appengine/logdog/coordinator/endpoints/services/registerStream_test.go

Issue 1910923002: LogDog: Add project namespace to service endpoint. (Closed) Base URL: https://github.com/luci/luci-go@logdog-project-coordinator-backend
Patch Set: Comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/logdog/coordinator/endpoints/services/registerStream_test.go
diff --git a/appengine/logdog/coordinator/endpoints/services/registerStream_test.go b/appengine/logdog/coordinator/endpoints/services/registerStream_test.go
index 1ac82c7fa71deec7f7ccc30b9ed3cef478e99890..2222141ef55938f6e7ddc9f895ef0266c6a33bac 100644
--- a/appengine/logdog/coordinator/endpoints/services/registerStream_test.go
+++ b/appengine/logdog/coordinator/endpoints/services/registerStream_test.go
@@ -41,6 +41,9 @@ func TestRegisterStream(t *testing.T) {
tt.EnableDelayedMutations(c)
ds.Get(c).Testable().Consistent(true)
+ fs := authtest.FakeState{}
+ c = auth.WithState(c, &fs)
+
var tap ct.ArchivalPublisher
svcStub := ct.Services{
AP: func() (coordinator.ArchivalPublisher, error) {
@@ -54,9 +57,6 @@ func TestRegisterStream(t *testing.T) {
svr := New()
- fs := authtest.FakeState{}
- c = auth.WithState(c, &fs)
-
Convey(`Returns Forbidden error if not a service.`, func() {
_, err := svr.RegisterStream(c, &logdog.RegisterStreamRequest{})
So(err, ShouldBeRPCPermissionDenied)
@@ -66,7 +66,7 @@ func TestRegisterStream(t *testing.T) {
fs.IdentityGroups = []string{"test-services"}
desc := ct.TestLogStreamDescriptor(c, "foo/bar")
- secret := bytes.Repeat([]byte{0xAA}, types.StreamSecretLength)
+ secret := bytes.Repeat([]byte{0xAA}, types.PrefixSecretLength)
Convey(`A stream registration request for "testing/+/foo/bar"`, func() {
req := logdog.RegisterStreamRequest{
@@ -196,7 +196,7 @@ func TestRegisterStream(t *testing.T) {
Convey(`Will not register a wrong-sized secret.`, func() {
req.Secret = nil
_, err := svr.RegisterStream(c, &req)
- So(err, ShouldBeRPCInvalidArgument, "Invalid secret length")
+ So(err, ShouldBeRPCInvalidArgument, "Invalid prefix secret")
})
Convey(`Will not register with an empty descriptor.`, func() {

Powered by Google App Engine
This is Rietveld 408576698