tools/LazyDecodeBitmap.h - Issue 19109002: Add the lazy decoder from PictureFlags to SkImageDecoder

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/LazyDecodeBitmap.h

Issue 19109002: Add the lazy decoder from PictureFlags to SkImageDecoder (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Move LazyDecodeBitmap to its own cpp/h. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2006 The Android Open Source Project
	scroggo 2013/07/15 18:02:41 2013 2013
	3 *

	4 * Use of this source code is governed by a BSD-style license that can be

	5 * found in the LICENSE file.

	6 */

	7

	8 #ifndef LazyDecodeBitmap_DEFINED

	9 #define LazyDecodeBitmap_DEFINED

	10

	11 #include "SkTypes.h"

	12 #include "SkBitmap.h"
	scroggo 2013/07/15 18:02:41 SkBitmap can be forward-declared here, and include SkBitmap can be forward-declared here, and included in the implementation file. sglez 2013/07/16 15:59:33 It compiles with just the forward declaration. Som Show quoted text On 2013/07/15 18:02:41, scroggo wrote: > SkBitmap can be forward-declared here, and included in the implementation file. It compiles with just the forward declaration. Some other header must be including SkBitmap. scroggo 2013/07/16 16:06:18 Although the forward declaration is enough to comp Show quoted text On 2013/07/16 15:59:33, sglez wrote: > On 2013/07/15 18:02:41, scroggo wrote: > > SkBitmap can be forward-declared here, and included in the implementation > file. > > It compiles with just the forward declaration. Some other header must be > including SkBitmap. Although the forward declaration is enough to compile, it is better practice to include the things you use. If the include chain ceases to include SkBitmap.h, you'll get a break here without changing LazyDecodeBitmap directly. Please add #include "SkBitmap.h" in LazyDecodeBitmap.cpp.
	13
	scroggo 2013/07/15 18:02:41 Maybe add a comment here, explaining its purpose. Maybe add a comment here, explaining its purpose. The current implementation is intertwined with PictureRenderingFlags and SkCommandLineFlags, which is not currently obvious by looking at the header.
	14 bool LazyDecodeBitmap(const void* buffer, size_t size, SkBitmap* bitmap);
	scroggo 2013/07/15 18:02:41 This should go inside a class or namespace. It cou This should go inside a class or namespace. It could go in the namespace for sk_tools, or something more specific to bitmap decoding.
	15

	16 #endif // LazyDecodeBitmap_DEFINED

OLD	NEW

« gyp/tools.gyp ('K') | « gyp/tools.gyp ('k') | tools/LazyDecodeBitmap.cpp » ('j') | tools/LazyDecodeBitmap.cpp » ('J')