build/all.gyp - Issue 1910843002: [iOS] Remove dependency on //mojo on iOS due to build failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/all.gyp

Issue 1910843002: [iOS] Remove dependency on //mojo on iOS due to build failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/all.gyp

diff --git a/build/all.gyp b/build/all.gyp

index 71ed6be3c9f737776390c1b80e0849dc90bafd54..3c160c3d89c61245d7f1d10298f9deb7f71d8272 100644

--- a/build/all.gyp

+++ b/build/all.gyp

@@ -53,15 +53,18 @@

# NOTE: This list of targets is present because

# mojo_base.gyp:mojo_base cannot be built on iOS, as

# javascript-related targets cause v8 to be built.

- '../mojo/mojo_base.gyp:mojo_common_lib',

- '../mojo/mojo_base.gyp:mojo_common_unittests',

- '../mojo/mojo_edk.gyp:mojo_system_impl',

- '../mojo/mojo_edk_tests.gyp:mojo_public_bindings_unittests',

- '../mojo/mojo_edk_tests.gyp:mojo_public_system_unittests',

- '../mojo/mojo_edk_tests.gyp:mojo_system_unittests',

- '../mojo/mojo_public.gyp:mojo_cpp_bindings',

- '../mojo/mojo_public.gyp:mojo_public_test_utils',

- '../mojo/mojo_public.gyp:mojo_system',

+ # TODO(crbug.com/605508): http://crrev.com/1832703002 introduced

+ # a dependency on //third_party/WebKit that cause build failures

+ # when using Xcode version of clang (loading clang plugin fails).

+ # '../mojo/mojo_base.gyp:mojo_common_lib',

+ # '../mojo/mojo_base.gyp:mojo_common_unittests',

+ # '../mojo/mojo_edk.gyp:mojo_system_impl',

+ # '../mojo/mojo_edk_tests.gyp:mojo_public_bindings_unittests',

Ken Rockot(use gerrit already) 2016/04/21 15:05:16 Pretty sure this is the only target here that actu

+ # '../mojo/mojo_edk_tests.gyp:mojo_public_system_unittests',

+ # '../mojo/mojo_edk_tests.gyp:mojo_system_unittests',

+ # '../mojo/mojo_public.gyp:mojo_cpp_bindings',

+ # '../mojo/mojo_public.gyp:mojo_public_test_utils',

+ # '../mojo/mojo_public.gyp:mojo_system',

'../google_apis/google_apis.gyp:google_apis_unittests',

'../skia/skia_tests.gyp:skia_unittests',

'../ui/base/ui_base_tests.gyp:ui_base_unittests',

« no previous file with comments | « no previous file | no next file » | no next file with comments »