Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1910843002:
[iOS] Remove dependency on //mojo on iOS due to build failure. (Closed)
|
Created:
4 years, 8 months ago by sdefresne Modified:
4 years, 8 months ago Reviewers:
Ken Rockot(use gerrit already), Nico, Eugene But (OOO till 7-30), rohitrao (ping after 24h) CC:
chromium-reviews, Ken Rockot(use gerrit already) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[iOS] Remove dependency on //mojo on iOS due to build failure.
http://crrev.com/1832703002 introduced a dependency on //third_party/WebKit
that cause build failures when using Xcode version of clang (loading clang
plugin fails).
As mojo is currently not used on iOS, remove the dependency temporarily
by not building mojo/mojo_edk_tests.gyp:mojo_public_bindings_unittests.
BUG=605508
Committed: https://crrev.com/babe70a9fc6770f67a4ce287c995d2bbcdaf0430
Cr-Commit-Position: refs/heads/master@{#389080}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Only remove dependency on mojo/mojo_edk_tests.gyp:mojo_public_bindings_unittests #Messages
Total messages: 24 (11 generated)
sdefresne@chromium.org changed reviewers: + rohitrao@chromium.org
Please take a look.
rohitrao@chromium.org changed reviewers: + eugenebut@chromium.org
Eugene should sign off on this if we're disabling mojo.
lgtm Ken, does Mojo pull WebKit by accident or by design? If we want to use Mojo on iOS we can't have dependency on WebKit.
rockot@chromium.org changed reviewers: + rockot@chromium.org
It's intentional, but see inline comment https://codereview.chromium.org/1910843002/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/1910843002/diff/1/build/all.gyp#newcode62 build/all.gyp:62: # '../mojo/mojo_edk_tests.gyp:mojo_public_bindings_unittests', Pretty sure this is the only target here that actually depends on Blink, because it tests blink bindings generation.
And to clarify: we should move the blink bindings tests to a separate target so the other unit tests still build (and eventually run) on iOS. That can be done later. For now, could you please try only disabling this target instead of everything under //mojo?
Description was changed from ========== [iOS] Remove dependency on //mojo on iOS due to build failure. http://crrev.com/1832703002 introduced a dependency on //third_party/WebKit that cause build failures when using Xcode version of clang (loading clang plugin fails). As mojo is currently not used on iOS, remove the dependency temporarily. BUG=605508 ========== to ========== [iOS] Remove dependency on //mojo on iOS due to build failure. http://crrev.com/1832703002 introduced a dependency on //third_party/WebKit that cause build failures when using Xcode version of clang (loading clang plugin fails). As mojo is currently not used on iOS, remove the dependency temporarily by not building mojo/mojo_edk_tests.gyp:mojo_public_bindings_unittests. BUG=605508 ==========
Patchset #2 (id:20001) has been deleted
rockot: done Note: the build failure only manifest when building with Xcode clang that is only exercised when building downstream official, so it will take some time to validate that it is sufficient to just disable that target.
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eugenebut@chromium.org Link to the patchset: https://codereview.chromium.org/1910843002/#ps40001 (title: "Only remove dependency on mojo/mojo_edk_tests.gyp:mojo_public_bindings_unittests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910843002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
sdefresne@chromium.org changed reviewers: + thakis@chromium.org
+thakis for OWNERS of build/all.gyp.
lgtm
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910843002/40001
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [iOS] Remove dependency on //mojo on iOS due to build failure. http://crrev.com/1832703002 introduced a dependency on //third_party/WebKit that cause build failures when using Xcode version of clang (loading clang plugin fails). As mojo is currently not used on iOS, remove the dependency temporarily by not building mojo/mojo_edk_tests.gyp:mojo_public_bindings_unittests. BUG=605508 ========== to ========== [iOS] Remove dependency on //mojo on iOS due to build failure. http://crrev.com/1832703002 introduced a dependency on //third_party/WebKit that cause build failures when using Xcode version of clang (loading clang plugin fails). As mojo is currently not used on iOS, remove the dependency temporarily by not building mojo/mojo_edk_tests.gyp:mojo_public_bindings_unittests. BUG=605508 Committed: https://crrev.com/babe70a9fc6770f67a4ce287c995d2bbcdaf0430 Cr-Commit-Position: refs/heads/master@{#389080} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/babe70a9fc6770f67a4ce287c995d2bbcdaf0430 Cr-Commit-Position: refs/heads/master@{#389080} |
