Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1910803002: Do not send bogus vsync refresh information. (Closed)

Created:
4 years, 8 months ago by qsr
Modified:
4 years, 8 months ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Do not send bogus vsync refresh information. During foregrounding, the android choreographer seems to be sometimes called twice with a very short interval in its parameters (24ns). This CL prevents the sync provider to report any vsync refresh superior to 1000Hz. R=etiennej@chromium.org, etiennej BUG=https://github.com/domokit/mojo/issues/758 Committed: https://chromium.googlesource.com/external/mojo/+/e1cc091a43b9e9455def41c5d2c8aaabfc30026b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M ui/gl/android/java/src/org/chromium/ui/gl/VSyncProvider.java View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
qsr
4 years, 8 months ago (2016-04-21 09:45:49 UTC) #1
etiennej
lgtm
4 years, 8 months ago (2016-04-21 11:25:36 UTC) #2
qsr
4 years, 8 months ago (2016-04-21 11:32:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1cc091a43b9e9455def41c5d2c8aaabfc30026b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698