Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1910753002: Add enablePerThreadHeap flag to ThreadState (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add enablePerThreadHeap flag to ThreadState BUG=591606 Committed: https://crrev.com/e5b8b2832fccc2cbe039698235669b029778f58d Cr-Commit-Position: refs/heads/master@{#389436} Committed: https://crrev.com/78e461f19f2a4b40969391bfd0e36c1778219a47 Cr-Commit-Position: refs/heads/master@{#392020}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -25 lines) Patch
M third_party/WebKit/Source/platform/WebThreadSupportingGC.h View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp View 1 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 3 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 2 3 4 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 2 3 4 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
keishi
PTAL
4 years, 8 months ago (2016-04-25 06:14:26 UTC) #2
haraken
LGTM https://codereview.chromium.org/1910753002/diff/20001/third_party/WebKit/Source/platform/heap/ThreadState.cpp File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right): https://codereview.chromium.org/1910753002/diff/20001/third_party/WebKit/Source/platform/heap/ThreadState.cpp#newcode115 third_party/WebKit/Source/platform/heap/ThreadState.cpp:115: RELEASE_ASSERT(!m_perThreadHeapEnabled); CHECK
4 years, 8 months ago (2016-04-25 06:57:12 UTC) #3
keishi
https://codereview.chromium.org/1910753002/diff/20001/third_party/WebKit/Source/platform/heap/ThreadState.cpp File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right): https://codereview.chromium.org/1910753002/diff/20001/third_party/WebKit/Source/platform/heap/ThreadState.cpp#newcode115 third_party/WebKit/Source/platform/heap/ThreadState.cpp:115: RELEASE_ASSERT(!m_perThreadHeapEnabled); On 2016/04/25 06:57:12, haraken wrote: > > CHECK ...
4 years, 8 months ago (2016-04-25 08:00:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910753002/40001
4 years, 8 months ago (2016-04-25 08:00:53 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-25 09:20:31 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e5b8b2832fccc2cbe039698235669b029778f58d Cr-Commit-Position: refs/heads/master@{#389436}
4 years, 8 months ago (2016-04-25 09:22:01 UTC) #10
keishi
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1919793002/ by keishi@chromium.org. ...
4 years, 8 months ago (2016-04-25 12:10:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910753002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910753002/60001
4 years, 7 months ago (2016-05-06 05:56:01 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-06 07:35:17 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 07:37:02 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/78e461f19f2a4b40969391bfd0e36c1778219a47
Cr-Commit-Position: refs/heads/master@{#392020}

Powered by Google App Engine
This is Rietveld 408576698