improve convolve speed of skpdiff using direct pointers

improve convolve speed of skpdiff using direct pointers

R=djsollen@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10099

[djsollen, 2013-07-12 18:07:10]

https://codereview.chromium.org/19107002/diff/1/experimental/skpdiff/SkPMetri...
File experimental/skpdiff/SkPMetric.cpp (right):

https://codereview.chromium.org/19107002/diff/1/experimental/skpdiff/SkPMetri...
experimental/skpdiff/SkPMetric.cpp:41: T * getRow(int y) const {
T* no space

https://codereview.chromium.org/19107002/diff/1/experimental/skpdiff/SkPMetri...
experimental/skpdiff/SkPMetric.cpp:206: float * rowPtrs[8];
float* here and on 210

https://codereview.chromium.org/19107002/diff/1/experimental/skpdiff/SkPMetri...
experimental/skpdiff/SkPMetric.cpp:208: rowPtrs[y] = imageL->getRow(y - radius);
how can you ensure that y is never greater than 7?

[Zach Reizner, 2013-07-12 18:51:43]

https://codereview.chromium.org/19107002/diff/1/experimental/skpdiff/SkPMetri...
File experimental/skpdiff/SkPMetric.cpp (right):

https://codereview.chromium.org/19107002/diff/1/experimental/skpdiff/SkPMetri...
experimental/skpdiff/SkPMetric.cpp:208: rowPtrs[y] = imageL->getRow(y - radius);
On 2013/07/12 18:07:10, djsollen wrote:
> how can you ensure that y is never greater than 7?

convolve is static and only ever called from pmetric. The filter always has a
size of 5. Thinking about it now, I may as well keep the filter here and avoid
future misuse of convolve.

[djsollen, 2013-07-12 19:23:47]

lgtm

[Zach Reizner, 2013-07-16 12:57:37]

Committed patchset #2 manually as r10099 (presubmit successful).

[tfarina, 2013-07-16 13:07:25]

https://codereview.chromium.org/19107002/diff/5001/experimental/skpdiff/SkPMe...
File experimental/skpdiff/SkPMetric.cpp (right):

https://codereview.chromium.org/19107002/diff/5001/experimental/skpdiff/SkPMe...
experimental/skpdiff/SkPMetric.cpp:203: const int matrixCount = sizeof(matrix) /
sizeof(float);
SK_ARRAY_COUNT?