cc/tiles/gpu_image_decode_controller.cc - Issue 1910663002: Fix ImageUploadTaskImpl with null dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/tiles/gpu_image_decode_controller.cc

Issue 1910663002: Fix ImageUploadTaskImpl with null dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@skskp

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/tiles/gpu_image_decode_controller.cc

diff --git a/cc/tiles/gpu_image_decode_controller.cc b/cc/tiles/gpu_image_decode_controller.cc

index 04a25a33fe87c1acaf02dadc9db3672dcd1456bf..44dfbdc70bfa906fdb83d2376ebe761d56d96314 100644

--- a/cc/tiles/gpu_image_decode_controller.cc

+++ b/cc/tiles/gpu_image_decode_controller.cc

@@ -110,7 +110,9 @@ class ImageUploadTaskImpl : public TileTask {

image_ref_(draw_image.image()),

source_prepare_tiles_id_(source_prepare_tiles_id) {

DCHECK(!SkipImage(draw_image));

- dependencies_.push_back(std::move(decode_dependency));

+ if (decode_dependency) {

vmpstr 2016/04/20 22:26:44 nit: no braces Also, the unittest makes it clear,

ericrk 2016/04/20 22:34:45 Done.

+ dependencies_.push_back(std::move(decode_dependency));

+ }

}

// Override from Task:

« no previous file with comments | « no previous file | cc/tiles/gpu_image_decode_controller_unittest.cc » ('j') | no next file with comments »