Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: components/ntp_snippets/ntp_snippets_service.h

Issue 1910633005: Display status message for "Add snippets" on chrome://snippets-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor edit (removing one empty line). Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippets_service.h
diff --git a/components/ntp_snippets/ntp_snippets_service.h b/components/ntp_snippets/ntp_snippets_service.h
index 4269f9413cfb2624f079f8407508ef81b3108df7..9ab2d48c7f96b237a5bde5a47c5230b3479eded1 100644
--- a/components/ntp_snippets/ntp_snippets_service.h
+++ b/components/ntp_snippets/ntp_snippets_service.h
@@ -79,6 +79,11 @@ class NTPSnippetsService : public KeyedService {
// suggestions from the suggestion service) and adds them to the current ones.
void FetchSnippetsFromHosts(const std::set<std::string>& hosts);
+ // Returns the last status message from the snippets fetcher.
+ const std::string& last_status() const {
+ return last_fetch_status_;
+ }
+
// (Re)schedules the periodic fetching of snippets. This is necessary because
// the schedule depends on the time of day
void RescheduleFetching();
@@ -123,7 +128,8 @@ class NTPSnippetsService : public KeyedService {
friend class NTPSnippetsServiceTest;
void OnSuggestionsChanged(const suggestions::SuggestionsProfile& suggestions);
- void OnSnippetsDownloaded(const std::string& snippets_json);
+ void OnSnippetsDownloaded(const std::string& snippets_json,
+ const std::string& status);
void OnJsonParsed(const std::string& snippets_json,
scoped_ptr<base::Value> parsed);
@@ -150,7 +156,7 @@ class NTPSnippetsService : public KeyedService {
bool HasDiscardedSnippet(const GURL& url) const;
- void RemoveExpiredSnippets();
+ void LoadingSnippetsFinished();
bool enabled_;
@@ -191,6 +197,8 @@ class NTPSnippetsService : public KeyedService {
scoped_ptr<NTPSnippetsFetcher::SnippetsAvailableCallbackList::Subscription>
snippets_fetcher_subscription_;
+ std::string last_fetch_status_;
+
// Timer that calls us back when the next snippet expires.
base::OneShotTimer expiry_timer_;

Powered by Google App Engine
This is Rietveld 408576698