Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: components/ntp_snippets/ntp_snippets_fetcher.h

Issue 1910633005: Display status message for "Add snippets" on chrome://snippets-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another minor polish + fixing the closely related bug 605520 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippets_fetcher.h
diff --git a/components/ntp_snippets/ntp_snippets_fetcher.h b/components/ntp_snippets/ntp_snippets_fetcher.h
index ae7fd6c97b85919d9d713199e98ebee26a11ad5e..b9ac552317c259fed5cab5b078e6661feaa1493b 100644
--- a/components/ntp_snippets/ntp_snippets_fetcher.h
+++ b/components/ntp_snippets/ntp_snippets_fetcher.h
@@ -21,9 +21,10 @@ namespace ntp_snippets {
// Fetches snippet data for the NTP from the server
class NTPSnippetsFetcher : public net::URLFetcherDelegate {
public:
- using SnippetsAvailableCallback = base::Callback<void(const std::string&)>;
+ using SnippetsAvailableCallback =
+ base::Callback<void(const std::string&, const std::string&)>;
Marc Treib 2016/04/21 13:47:20 I'd add comments ("fake names") for the two string
Bernhard Bauer 2016/04/21 16:28:40 They don't even have to be in comments -- the sign
jkrcal 2016/04/22 09:30:28 Done.
using SnippetsAvailableCallbackList =
- base::CallbackList<void(const std::string&)>;
+ base::CallbackList<void(const std::string&, const std::string&)>;
NTPSnippetsFetcher(
scoped_refptr<base::SequencedTaskRunner> file_task_runner,

Powered by Google App Engine
This is Rietveld 408576698