Display status message for "Add snippets" on chrome://snippets-internals

components/ntp_snippets/ntp_snippets_service.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_
 #define COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_
 
 #include <stddef.h>
 
 #include <set>
@@ skipping 61 matching lines @@
 
   // Inherited from KeyedService.
   void Shutdown() override;
 
   // Fetches snippets from the server and adds them to the current ones.
   void FetchSnippets();
   // Fetches snippets from the server for specified hosts (overriding
   // suggestions from the suggestion service) and adds them to the current ones.
   void FetchSnippetsFromHosts(const std::set<std::string>& hosts);
 
+  // Returns the last status message from the snippets fetcher.
+  const std::string get_last_status() const {

[Marc Treib, 2016/04/21 13:47:21]

Just "last_status", no "get".
Also, return a reference.

[jkrcal, 2016/04/22 09:30:28]

Done.

+    return snippets_fetcher_last_status_;
+  }
+
   // (Re)schedules the periodic fetching of snippets. This is necessary because
   // the schedule depends on the time of day
   void RescheduleFetching();
 
   // Deletes all currently stored snippets.
   void ClearSnippets();
 
   // Discards the snippet with the given |url|, if it exists. Returns true iff
   // a snippet was discarded.
   bool DiscardSnippet(const GURL& url);
@@ skipping 24 matching lines @@
   //  for (auto& snippet : *service) {
   //    // |snippet| here is a const object.
   //  }
   const_iterator begin() const { return const_iterator(snippets_.begin()); }
   const_iterator end() const { return const_iterator(snippets_.end()); }
 
  private:
   friend class NTPSnippetsServiceTest;
 
   void OnSuggestionsChanged(const suggestions::SuggestionsProfile& suggestions);
-  void OnSnippetsDownloaded(const std::string& snippets_json);
+  void OnSnippetsDownloaded(const std::string& snippets_json,
+                            const std::string& status);
 
   void OnJsonParsed(const std::string& snippets_json,
                     scoped_ptr<base::Value> parsed);
   void OnJsonError(const std::string& snippets_json, const std::string& error);
 
   // Expects a top-level dictionary containing a "recos" list, which will be
   // passed to LoadFromListValue().
   bool LoadFromValue(const base::Value& value);
 
   // Expects a list of dictionaries each containing a "contentInfo" dictionary
   // with keys matching the properties of a snippet (url, title, site_title,
   // etc...). The URL is the only mandatory value.
   bool LoadFromListValue(const base::ListValue& list);
 
   // TODO(treib): Investigate a better storage, maybe LevelDB or SQLite?
   void LoadSnippetsFromPrefs();
   void StoreSnippetsToPrefs();
 
   void LoadDiscardedSnippetsFromPrefs();
   void StoreDiscardedSnippetsToPrefs();
 
   std::set<std::string> GetSnippetHostsFromPrefs() const;
   void StoreSnippetHostsToPrefs(const std::set<std::string>& hosts);
 
   bool HasDiscardedSnippet(const GURL& url) const;
 
-  void RemoveExpiredSnippets();
+  void LoadingSnippetsFinished();
 
   bool enabled_;
 
   PrefService* pref_service_;
 
   suggestions::SuggestionsService* suggestions_service_;
 
   // The SequencedTaskRunner on which file system operations will be run.
   scoped_refptr<base::SequencedTaskRunner> file_task_runner_;
 
@@ skipping 20 matching lines @@
       suggestions::SuggestionsService::ResponseCallbackList::Subscription;
   scoped_ptr<SuggestionsSubscription> suggestions_service_subscription_;
 
   // The snippets fetcher.
   scoped_ptr<NTPSnippetsFetcher> snippets_fetcher_;
 
   // The subscription to the snippets fetcher.
   scoped_ptr<NTPSnippetsFetcher::SnippetsAvailableCallbackList::Subscription>
       snippets_fetcher_subscription_;
 
+  std::string snippets_fetcher_last_status_;

[Marc Treib, 2016/04/21 13:47:21]

IMO this name is a bit misleading, ad it doesn't always contain a status from
the fetcher. Maybe "last_fetch_status_"?

[jkrcal, 2016/04/22 09:30:28]

Done.

+
   // Timer that calls us back when the next snippet expires.
   base::OneShotTimer expiry_timer_;
 
   ParseJSONCallback parse_json_callback_;
 
   base::WeakPtrFactory<NTPSnippetsService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NTPSnippetsService);
 };
 
 class NTPSnippetsServiceObserver {
  public:
   // Sent every time the service loads a new set of data.
   virtual void NTPSnippetsServiceLoaded() = 0;
   // Sent when the service is shutting down.
   virtual void NTPSnippetsServiceShutdown() = 0;
 
  protected:
   virtual ~NTPSnippetsServiceObserver() {}
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_