Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1910633004: Mac video: Enable AVSampleBufferDisplayLayer for h264 (Closed)

Created:
4 years, 8 months ago by ccameron
Modified:
4 years, 8 months ago
Reviewers:
erikchen
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac video: Enable AVSampleBufferDisplayLayer for h264 Create plumbing to pass the CVPixelBufferRef from the GPU video decoder directly to the AVSampleBufferDisplayLayer. Re-enable AVSampleBufferDisplayLayer, but only for hardware decoded frames, for the moment. Once this bakes, we can enable software decoded frames. BUG=594449 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3d2efd77e4af7feee0950ea2443af4cca7089018 Cr-Commit-Position: refs/heads/master@{#388724}

Patch Set 1 #

Patch Set 2 : Update comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -64 lines) Patch
M gpu/ipc/service/image_transport_surface_overlay_mac.mm View 1 chunk +7 lines, -4 lines 0 comments Download
M ui/accelerated_widget_mac/ca_layer_tree_mac.h View 6 chunks +32 lines, -23 lines 0 comments Download
M ui/accelerated_widget_mac/ca_layer_tree_mac.mm View 1 2 11 chunks +57 lines, -30 lines 0 comments Download
M ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm View 21 chunks +93 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
ccameron
4 years, 8 months ago (2016-04-20 22:29:20 UTC) #3
erikchen
lgtm
4 years, 8 months ago (2016-04-20 22:41:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910633004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910633004/40001
4 years, 8 months ago (2016-04-21 07:36:43 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-21 08:39:41 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:32:46 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3d2efd77e4af7feee0950ea2443af4cca7089018
Cr-Commit-Position: refs/heads/master@{#388724}

Powered by Google App Engine
This is Rietveld 408576698