Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: cc/layers/layer.h

Issue 19106007: cc: Allow the main thread to cancel commits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address danakj's review comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/layer.cc » ('j') | cc/scheduler/scheduler_state_machine.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer.h
diff --git a/cc/layers/layer.h b/cc/layers/layer.h
index 077eb2c649af694078f53a3bd6941ed5a71bbf6a..6a3ca367943efbde4e7c44046a971b52acbcd63c 100644
--- a/cc/layers/layer.h
+++ b/cc/layers/layer.h
@@ -393,7 +393,18 @@ class CC_EXPORT Layer : public base::RefCounted<Layer>,
Layer();
+ // These SetNeeds functions are in order of severity of update:
+ //
+ // Called when this layer has been modified in some way, but isn't sure
+ // that it needs a commit yet. It needs CalcDrawProperties and UpdateLayers
+ // before it knows whether or not a commit is required.
+ void SetNeedsUpdate();
+ // Called when a property has been modified in a way that the layer
+ // knows immediately that a commit is required. This implies SetNeedsUpdate
+ // as well as SetNeedsPushProperties to push that property.
void SetNeedsCommit();
+ // Called when there's been a change in layer structure. Implies both
+ // SetNeedsUpdate and SetNeedsCommit, but not SetNeedsPushProperties.
void SetNeedsFullTreeSync();
bool IsPropertyChangeAllowed() const;
@@ -434,7 +445,7 @@ class CC_EXPORT Layer : public base::RefCounted<Layer>,
int layer_id_;
// When true, the layer is about to perform an update. Any commit requests
- // will be handled implcitly after the update completes.
+ // will be handled implicitly after the update completes.
bool ignore_set_needs_commit_;
private:
« no previous file with comments | « no previous file | cc/layers/layer.cc » ('j') | cc/scheduler/scheduler_state_machine.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698