skia.org: Update all fiddles for fiddle 2.0

skia.org: Update all fiddles for fiddle 2.0.

The images won't show up in the preview, which won't happen until I switch over to fiddle 2.0 in production later today.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1910593005
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005

Committed: https://skia.googlesource.com/skia/+/1c2a2fe3c81af0d5b35224dc06cbd1a82a474ec7

[jcgregorio, 2016-04-21 18:25:03]

Description was changed from

==========
skia.org: Update all fiddles for fiddle 2.0

BUG=skia:
==========

to

==========
skia.org: Update all fiddles for fiddle 2.0

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005
==========

[jcgregorio, 2016-04-22 15:04:04]

Description was changed from

==========
skia.org: Update all fiddles for fiddle 2.0

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005
==========

to

==========
skia.org: Update all fiddles for fiddle 2.0.

The images won't show up in the preview, which won't happen until I switch over
to fiddle 2.0 in production later today.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005
==========

[jcgregorio, 2016-04-22 15:04:04]

jcgregorio@google.com changed reviewers:
+ halcanary@google.com

[jcgregorio, 2016-04-22 15:31:47]

https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skcanvas.md
File site/user/api/skcanvas.md (right):

https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skcanvas...
site/user/api/skcanvas.md:135: canvas->drawBitmapRect(source, rect2, &paint);
Or should this be:

   canvas->drawBitmapRect(source, rect2, nullptr);

https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skpaint.md
File site/user/api/skpaint.md (right):

https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skpaint....
site/user/api/skpaint.md:112: specified in the call to `MakeLinear()`. The
shader object that is
Does the text after this, about reference-counting, need to be updated in light
of sk_sp?

[hal.canary, 2016-04-22 15:36:00]

lgtm

https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skpaint.md
File site/user/api/skpaint.md (right):

https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skpaint....
site/user/api/skpaint.md:112: specified in the call to `MakeLinear()`. The
shader object that is
On 2016/04/22 15:31:47, jcgregorio wrote:
> Does the text after this, about reference-counting, need to be updated in
light
> of sk_sp?

yes

https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skpaint....
site/user/api/skpaint.md:257: SkShader::kRepeat_TileMode ,
indentation

[jcgregorio, 2016-04-22 15:43:21]

https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skpaint.md
File site/user/api/skpaint.md (right):

https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skpaint....
site/user/api/skpaint.md:112: specified in the call to `MakeLinear()`. The
shader object that is
On 2016/04/22 at 15:36:00, Hal Canary wrote:
> On 2016/04/22 15:31:47, jcgregorio wrote:
> > Does the text after this, about reference-counting, need to be updated in
light
> > of sk_sp?
> 
> yes

OK, to what? Or do you want to tackle that in a separate CL? Maybe sk_sp needs
its own page that can be linked to from here.

https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skpaint....
site/user/api/skpaint.md:257: SkShader::kRepeat_TileMode ,
On 2016/04/22 at 15:36:00, Hal Canary wrote:
> indentation

Fixed.

[hal.canary, 2016-04-22 15:44:45]

On 2016/04/22 15:43:21, jcgregorio wrote:
>
https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skpaint.md
> File site/user/api/skpaint.md (right):
> 
>
https://codereview.chromium.org/1910593005/diff/160001/site/user/api/skpaint....
> site/user/api/skpaint.md:112: specified in the call to `MakeLinear()`. The
> shader object that is
> On 2016/04/22 at 15:36:00, Hal Canary wrote:
> > On 2016/04/22 15:31:47, jcgregorio wrote:
> > > Does the text after this, about reference-counting, need to be updated in
> light
> > > of sk_sp?
> > 
> > yes
> 
> OK, to what? Or do you want to tackle that in a separate CL? Maybe sk_sp needs
> its own page that can be linked to from here.
> 

A separate CL is fine.

[jcgregorio, 2016-04-22 16:23:31]

Description was changed from

==========
skia.org: Update all fiddles for fiddle 2.0.

The images won't show up in the preview, which won't happen until I switch over
to fiddle 2.0 in production later today.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005
==========

to

==========
skia.org: Update all fiddles for fiddle 2.0.

The images won't show up in the preview, which won't happen until I switch over
to fiddle 2.0 in production later today.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005
COMMIT=false
==========

[jcgregorio, 2016-04-22 18:24:30]

Description was changed from

==========
skia.org: Update all fiddles for fiddle 2.0.

The images won't show up in the preview, which won't happen until I switch over
to fiddle 2.0 in production later today.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005
COMMIT=false
==========

to

==========
skia.org: Update all fiddles for fiddle 2.0.

The images won't show up in the preview, which won't happen until I switch over
to fiddle 2.0 in production later today.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005
==========

[jcgregorio, 2016-04-22 18:24:35]

The CQ bit was checked by jcgregorio@google.com

[jcgregorio, 2016-04-22 18:24:35]

The patchset sent to the CQ was uploaded after l-g-t-m from halcanary@google.com
Link to the patchset: https://codereview.chromium.org/1910593005/#ps180001
(title: " ")

[commit-bot: I haz the power, 2016-04-22 18:24:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910593005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910593005/180001

[commit-bot: I haz the power, 2016-04-22 18:25:45]

Description was changed from

==========
skia.org: Update all fiddles for fiddle 2.0.

The images won't show up in the preview, which won't happen until I switch over
to fiddle 2.0 in production later today.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005
==========

to

==========
skia.org: Update all fiddles for fiddle 2.0.

The images won't show up in the preview, which won't happen until I switch over
to fiddle 2.0 in production later today.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005

Committed:
https://skia.googlesource.com/skia/+/1c2a2fe3c81af0d5b35224dc06cbd1a82a474ec7
==========

[commit-bot: I haz the power, 2016-04-22 18:25:46]

Committed patchset #10 (id:180001) as
https://skia.googlesource.com/skia/+/1c2a2fe3c81af0d5b35224dc06cbd1a82a474ec7