Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1910553003: Revert of Remove flaky timeout suppression for TexImage2D with RGB/UNSIGNED_BYTE. (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, jochen (gone - plz use gerrit), sigbjornf
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove flaky timeout suppression for TexImage2D with RGB/UNSIGNED_BYTE. (patchset #1 id:1 of https://codereview.chromium.org/1904873002/ ) Reason for revert: Unfortunately this test is still flaky. See https://bugs.chromium.org/p/chromium/issues/detail?id=596622#c36 . Original issue's description: > Remove flaky timeout suppression for TexImage2D with RGB/UNSIGNED_BYTE. > > An unscientific sampling of linux_chromium_rel_ng try jobs shows that > this test is not flakily failing any more. I suspect the fix for Issue > 586183 has fixed it, and am going to duplicate Issue 596622 into it. > > BUG=596622 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596622 Committed: https://crrev.com/b5c793fd9fff9bdf38337ee320795609c2319db0 Cr-Commit-Position: refs/heads/master@{#388811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ken Russell (switch to Gerrit)
Created Revert of Remove flaky timeout suppression for TexImage2D with RGB/UNSIGNED_BYTE.
4 years, 8 months ago (2016-04-21 17:54:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910553003/1
4 years, 8 months ago (2016-04-21 17:55:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 17:56:35 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:36:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5c793fd9fff9bdf38337ee320795609c2319db0
Cr-Commit-Position: refs/heads/master@{#388811}

Powered by Google App Engine
This is Rietveld 408576698