Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 191053002: Turn SVGTextMetricsBuilder into a namespace (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Turn SVGTextMetricsBuilder into a namespace Said class does not carry any state, so turn it into a namespace, marking previous methods static as appropriate and modify callers. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M Source/core/rendering/svg/SVGTextLayoutAttributesBuilder.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutAttributesBuilder.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.h View 1 chunk +4 lines, -12 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
fs
6 years, 9 months ago (2014-03-07 16:40:57 UTC) #1
pdr.
On 2014/03/07 16:40:57, fs wrote: We actually don't use this patten much in Blink so ...
6 years, 9 months ago (2014-03-07 18:49:05 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-07 18:49:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/191053002/1
6 years, 9 months ago (2014-03-07 18:49:36 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 19:19:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-07 19:19:51 UTC) #6
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-07 19:44:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/191053002/1
6 years, 9 months ago (2014-03-07 19:44:44 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 04:02:00 UTC) #9
Message was sent while issue was closed.
Change committed as 168769

Powered by Google App Engine
This is Rietveld 408576698