Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1910523002: Remove extraneous USE_NSS_VERIFIER macros (Closed)

Created:
4 years, 8 months ago by svaldez
Modified:
4 years, 8 months ago
Reviewers:
davidben, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove extraneous USE_NSS_VERIFIER macros BUG=604728 Committed: https://crrev.com/f9fd1be22cfa3c1e87e2a8d8660b4c2f64390d37 Cr-Commit-Position: refs/heads/master@{#388546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/cronet/ios/cronet_environment.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/test_root_certs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
svaldez
Missed changing a USE_NSS_VERIFIER to USE_NSS_CERTS as part of the massive rename.
4 years, 8 months ago (2016-04-20 17:24:24 UTC) #2
xunjieli
lgtm
4 years, 8 months ago (2016-04-20 17:26:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910523002/1
4 years, 8 months ago (2016-04-20 17:27:06 UTC) #5
davidben
lgtm
4 years, 8 months ago (2016-04-20 17:36:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 19:23:32 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:19 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f9fd1be22cfa3c1e87e2a8d8660b4c2f64390d37
Cr-Commit-Position: refs/heads/master@{#388546}

Powered by Google App Engine
This is Rietveld 408576698