Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1910503002: S390: [Interpreter] Remove register file register and replace with LoadParentFramePointer. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [Interpreter] Remove register file register and replace with LoadParentFramePointer. Port 623ad7de882019dff10168ef53bd539f01ef5b93 Original commit message: Removes the register file machine register from the interpreter and replaces it will loads from the parent frame pointer. As part of this change the raw operand values for register values changes to enable the interpreter to keep using the operand value as the offset from the parent frame pointer. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/b2a36b9e3cd82ce13cf8a62744df8b6dfbab825b Cr-Commit-Position: refs/heads/master@{#35672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
M src/s390/builtins-s390.cc View 4 chunks +5 lines, -18 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-20 16:47:46 UTC) #1
JoranSiu
On 2016/04/20 16:47:46, john.yan wrote: > PTAL lgtm
4 years, 8 months ago (2016-04-20 16:48:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910503002/1
4 years, 8 months ago (2016-04-20 16:53:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 17:19:17 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:13:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2a36b9e3cd82ce13cf8a62744df8b6dfbab825b
Cr-Commit-Position: refs/heads/master@{#35672}

Powered by Google App Engine
This is Rietveld 408576698