Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 1910483002: Makes aura::LayoutManager be destroyed before properties (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes aura::LayoutManager be destroyed before properties I want to store some state in properties that needs to be valid from the LayoutManagers destructor. This means the LayoutManager needs to be destroyed before owned properties. BUG=603369 TEST=none R=ben@chromium.org Committed: https://crrev.com/085a2833a750add15969c26819dfafd1ec610ebe Cr-Commit-Position: refs/heads/master@{#388556}

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
M ui/aura/window.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/window_unittest.cc View 4 chunks +90 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 8 months ago (2016-04-20 18:24:39 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-20 18:25:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910483002/20001
4 years, 8 months ago (2016-04-20 18:56:32 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 19:40:55 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:44 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/085a2833a750add15969c26819dfafd1ec610ebe
Cr-Commit-Position: refs/heads/master@{#388556}

Powered by Google App Engine
This is Rietveld 408576698