third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp - Issue 1910463002: Implement MediaStreamTrack.getConstraints

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

Issue 1910463002: Implement MediaStreamTrack.getConstraints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments on layout test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

index d2ddce91c5220788b2d42a2a461e81e1fcbcef8b..9d6aa009fa9eb5f79b63e929463eebebc9656fbf 100644

--- a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

@@ -168,11 +168,13 @@ void UserMediaRequest::succeed(MediaStreamDescriptor* streamDescriptor)

MediaStreamTrackVector audioTracks = stream->getAudioTracks();

for (MediaStreamTrackVector::iterator iter = audioTracks.begin(); iter != audioTracks.end(); ++iter) {

(*iter)->component()->source()->setConstraints(m_audio);

+ (*iter)->setConstraints(m_audio);

}

MediaStreamTrackVector videoTracks = stream->getVideoTracks();

for (MediaStreamTrackVector::iterator iter = videoTracks.begin(); iter != videoTracks.end(); ++iter) {

(*iter)->component()->source()->setConstraints(m_video);

+ (*iter)->setConstraints(m_video);

}

m_successCallback->handleEvent(stream);