Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1910453004: Removing Dr. Memory exclusion for the SecurityKeyReadyImpl.MultipleMessage test (Closed)

Created:
4 years, 8 months ago by joedow
Modified:
4 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing Dr. Memory exclusion for the SecurityKeyReadyImpl.MultipleMessage test I've fixed the underlying cause of the issue, verified it locally, and submitted it yesterday: https://codereview.chromium.org/1900733002/ This change removes the exceptions from the text file so they can start running on the Dr. Memory bot. BUG=603357 Committed: https://crrev.com/6be0c79c939096ab34fa4b3688c225caa798f054 Cr-Commit-Position: refs/heads/master@{#388657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
joedow
Removing the Dr. Memory exception for the unit tests I fixed yesterday. PTAL! Thanks, Joe
4 years, 8 months ago (2016-04-20 21:43:32 UTC) #2
Sergey Ulanov
lgtm
4 years, 8 months ago (2016-04-20 21:44:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910453004/1
4 years, 8 months ago (2016-04-20 21:46:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/215911)
4 years, 8 months ago (2016-04-20 22:50:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910453004/1
4 years, 8 months ago (2016-04-21 00:07:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 01:24:40 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:30:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6be0c79c939096ab34fa4b3688c225caa798f054
Cr-Commit-Position: refs/heads/master@{#388657}

Powered by Google App Engine
This is Rietveld 408576698